[Bug]: After upgrade to NC 29.0.0.7 the upgrade mechanism seems to be broken #44157
Comments
stefan-niedermann
added
bug
0. Needs triage
|
It looks like a regression of nextcloud/updater#535 |
|
I can confirm that the changes of nextcloud/updater#535 are present in my instance:
|
|
Cc @nextcloud/server-backend |
|
@stefan-niedermann What do you have in this apps.config.php file? |
|
This is the complete content of the file (I did not create, touch, modify or edit it manually): <?php
$CONFIG = array (
'apps_paths' => array (
0 => array (
'path' => OC::$SERVERROOT.'/apps',
'url' => '/apps',
'writable' => false,
),
1 => array (
'path' => OC::$SERVERROOT.'/custom_apps',
'url' => '/custom_apps',
'writable' => true,
),
),
'appsallowlist' => getenv('APPS_ALLOWLIST') ? explode(" ", getenv('APPS_ALLOWLIST')) : false,
);I can only guess that it has been created automatically by AIO to pass by default enabled apps via environment variables, but this is just a guess. |
|
Personally I would revert the PR as usually all settings in additional *.config.php should directly be written back to the normal config.php ... |
Strange, I always considered that a bug we hopefully address some time ;) It also does not work if you set the configuration file to read only and the configuration from the additional files have precedence over config.php 😢 I assume the apps_paths are also in config.php and OC::$SERVERROOT is resolved to the file system path @stefan-niedermann ? |
If so then please let us also add a command to write things out to config.php. |
This is a partial extract of the 'apps_paths' =>
array (
0 =>
array (
'path' => '/var/www/html/apps',
'url' => '/apps',
'writable' => false,
),
1 =>
array (
'path' => '/var/www/html/custom_apps',
'url' => '/custom_apps',
'writable' => true,
),
)
Not sure what exactly you mean by this? Given the paths are string literals in the |
That OC::$SERVERROOT from apps.config.php ends up in config.php as /var/www/html ;) |
|
Alright, I monkey patched the This seemed to work, fine for me. Please feel free to close this issue from my side. If you think this is an actual bug that should get fixed, feel free to keep it open. 🙂 |
|
Also used by the micro-services Docker images: |
|
Closed by nextcloud/updater#540 |
Bug description
After upgrading to NC 29.0.0.2 Beta via CLI, trying to further upgrade the instance fails:
Steps to reproduce
php updater/updater.phar --no-interaction --no-backup && php occ app:enable nextcloud-aio --forcetwiceExpected behavior
Upgrading should work or simply detect no new versions. This looks more like a crash.
Installation method
Official All-in-One appliance
Nextcloud Server version
master
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.1
Web server
Nginx
Database engine version
None
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 22 to 23)
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
{ "system": { "one-click-instance": true, "one-click-instance.user-limit": 100, "memcache.local": "\\OC\\Memcache\\APCu", "apps_paths": [ { "path": "\/var\/www\/html\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/www\/html\/custom_apps", "url": "\/custom_apps", "writable": true } ], "check_data_directory_permissions": false, "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "password": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "overwritehost": "cloud.example.com", "overwriteprotocol": "https", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "localhost", "cloud.example.com" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "pgsql", "version": "29.0.0.7", "overwrite.cli.url": "https:\/\/cloud.example.com\/", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "maintenance": false, "loglevel": "2", "log_type": "file", "logfile": "\/var\/www\/html\/data\/nextcloud.log", "log_rotate_size": "10485760", "log.condition": { "apps": [ "admin_audit" ] }, "preview_max_x": "2048", "preview_max_y": "2048", "jpeg_quality": "60", "enabledPreviewProviders": { "1": "OC\\Preview\\Image", "2": "OC\\Preview\\MarkDown", "3": "OC\\Preview\\MP3", "4": "OC\\Preview\\TXT", "5": "OC\\Preview\\OpenDocument", "6": "OC\\Preview\\Movie", "7": "OC\\Preview\\Krita", "0": "OC\\Preview\\Imaginary" }, "enable_previews": true, "upgrade.disable-web": true, "mail_smtpmode": "smtp", "trashbin_retention_obligation": "auto, 30", "versions_retention_obligation": "auto, 30", "activity_expire_days": "30", "simpleSignUpLink.shown": false, "share_folder": "\/Shared", "one-click-instance.link": "https:\/\/nextcloud.com\/all-in-one\/", "upgrade.cli-upgrade-link": "https:\/\/github.com\/nextcloud\/all-in-one\/discussions\/2726", "updatedirectory": "\/nc-updater", "davstorage.request_timeout": 3600, "htaccess.RewriteBase": "\/", "dbpersistent": false, "files_external_allow_create_new_local": false, "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "allow_local_remote_servers": true, "preview_imaginary_url": "***REMOVED SENSITIVE VALUE***", "default_phone_region": "DE", "mail_sendmailmode": "smtp", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpauth": 1, "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "ssl", "appsallowlist": false, "updater.release.channel": "stable", "app_install_overwrite": [ "nextcloud-aio", "news", "notify_push", "fulltextsearch", "fulltextsearch_elasticsearch", "files_fulltextsearch", "richdocuments", "polls", "files_rightclick" ], "maintenance_window_start": 1 } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
[ {"reqId":"IxrSWVpnKArTgRr2sOkB","level":3,"time":"2024-03-09T18:09:26+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"Class \"OC\\BackgroundJob\\TimedJob\" not found","userAgent":"--","version":"29.0.0.7","exception":{"Exception":"Error","Message":"Class \"OC\\BackgroundJob\\TimedJob\" not found","Code":0,"Trace":[{"file":"/var/www/html/lib/composer/composer/ClassLoader.php","line":576,"function":"include"},{"file":"/var/www/html/lib/composer/composer/ClassLoader.php","line":427,"function":"Composer\\Autoload\\{closure}","args":["*** sensitive parameters replaced ***"]},{"function":"loadClass","class":"Composer\\Autoload\\ClassLoader","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php","line":126,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php","line":146,"function":"resolve","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php","line":469,"function":"query","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/ServerContainer.php","line":155,"function":"queryNoFallback","class":"OC\\AppFramework\\DependencyInjection\\DIContainer","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php","line":64,"function":"query","class":"OC\\ServerContainer","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/public/Server.php","line":55,"function":"get","class":"OC\\AppFramework\\Utility\\SimpleContainer","type":"->","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/BackgroundJob/JobList.php","line":326,"function":"get","class":"OCP\\Server","type":"::","args":["OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities"]},{"file":"/var/www/html/lib/private/BackgroundJob/JobList.php","line":235,"function":"buildJob","class":"OC\\BackgroundJob\\JobList","type":"->","args":[[8625,"OCA\\Richdocuments\\Backgroundjobs\\ObtainCapabilities","null",0,1710007501,"And 4 more entries, set log level to debug to see all entries"]]},{"file":"/var/www/html/cron.php","line":163,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->","args":[true]}],"File":"/var/www/html/custom_apps/richdocuments/lib/Backgroundjobs/ObtainCapabilities.php","Line":29,"message":"Class \"OC\\BackgroundJob\\TimedJob\" not found","exception":[],"CustomMessage":"Class \"OC\\BackgroundJob\\TimedJob\" not found"},"id":"65f036ef1f3bd"} {"reqId":"poOmvdzB3Sxo2YxkzfLN","level":3,"time":"2024-03-09T18:07:46+00:00","remoteAddr":"79.225.81.230","user":"admin","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/user_status/api/v1/predefined_statuses?format=json","message":"Class \"OCA\\UserStatus\\Controller\\UserStatusController\" does not exist","userAgent":"Mozilla/5.0 (Android) Nextcloud-android/3.28.0","version":"29.0.0.7","exception":{"Exception":"ReflectionException","Message":"Class \"OCA\\UserStatus\\Controller\\UserStatusController\" does not exist","Code":-1,"Trace":[{"file":"/var/www/html/lib/private/Route/Router.php","line":469,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\UserStatus\\Controller\\UserStatusController"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":161,"function":"getAttributeRoutes","class":"OC\\Route\\Router","type":"->","args":["user_status"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":286,"function":"loadRoutes","class":"OC\\Route\\Router","type":"->","args":["user_status"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":330,"function":"findMatchingRoute","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/apps/user_status/api/v1/predefined_statuses"]},{"file":"/var/www/html/ocs/v1.php","line":66,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/apps/user_status/api/v1/predefined_statuses"]},{"file":"/var/www/html/ocs/v2.php","line":23,"args":["/var/www/html/ocs/v1.php"],"function":"require_once"}],"File":"/var/www/html/lib/private/Route/Router.php","Line":469,"message":"Class \"OCA\\UserStatus\\Controller\\UserStatusController\" does not exist","exception":[],"CustomMessage":"Class \"OCA\\UserStatus\\Controller\\UserStatusController\" does not exist"},"id":"65f036ef1f418"}, {"reqId":"zWRV1LrgNwu6KKwyiOKW","level":3,"time":"2024-03-09T18:05:10+00:00","remoteAddr":"79.225.81.230","user":"admin","app":"no app in context","method":"GET","url":"/apps/files","message":"App files_rightclick threw an error during app.php load and will be disabled: Call to undefined method OC\\Server::getEventDispatcher()","userAgent":"Mozilla/5.0 (Android 13; Mobile; rv:123.0) Gecko/123.0 Firefox/123.0","version":"29.0.0.7","exception":{"Exception":"Error","Message":"Call to undefined method OC\\Server::getEventDispatcher()","Code":0,"Trace":[{"file":"/var/www/html/lib/private/App/AppManager.php","line":525,"function":"require_once"},{"file":"/var/www/html/lib/private/App/AppManager.php","line":416,"function":"requireAppFile","class":"OC\\App\\AppManager","type":"::","args":["/var/www/html/custom_apps/files_rightclick"]},{"file":"/var/www/html/lib/private/App/AppManager.php","line":216,"function":"loadApp","class":"OC\\App\\AppManager","type":"->","args":["files_rightclick"]},{"file":"/var/www/html/lib/private/legacy/OC_App.php","line":128,"function":"loadApps","class":"OC\\App\\AppManager","type":"->","args":[[]]},{"file":"/var/www/html/lib/base.php","line":1030,"function":"loadApps","class":"OC_App","type":"::","args":[]},{"file":"/var/www/html/index.php","line":49,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/custom_apps/files_rightclick/appinfo/app.php","Line":8,"message":"App files_rightclick threw an error during app.php load and will be disabled: Call to undefined method OC\\Server::getEventDispatcher()","exception":[],"CustomMessage":"App files_rightclick threw an error during app.php load and will be disabled: Call to undefined method OC\\Server::getEventDispatcher()"},"id":"65f036ef1f495"}, {"reqId":"ah20b1Cq3Geug7pmpNqF","level":3,"time":"2024-03-09T17:37:38+00:00","remoteAddr":"79.225.81.230","user":"admin","app":"index","method":"GET","url":"/index.php/apps/news/api/v1-2/feeds?","message":"Class \"OCA\\News\\Controller\\FolderApiController\" does not exist","userAgent":"Mozilla/5.0 (Android) Nextcloud-android/3.28.0","version":"29.0.0.7","exception":{"Exception":"ReflectionException","Message":"Class \"OCA\\News\\Controller\\FolderApiController\" does not exist","Code":-1,"Trace":[{"file":"/var/www/html/lib/private/Route/Router.php","line":469,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\News\\Controller\\FolderApiController"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":161,"function":"getAttributeRoutes","class":"OC\\Route\\Router","type":"->","args":["news"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":279,"function":"loadRoutes","class":"OC\\Route\\Router","type":"->","args":["news"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":330,"function":"findMatchingRoute","class":"OC\\Route\\Router","type":"->","args":["/apps/news/api/v1-2/feeds"]},{"file":"/var/www/html/lib/base.php","line":1050,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/news/api/v1-2/feeds"]},{"file":"/var/www/html/index.php","line":49,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/Route/Router.php","Line":469,"message":"Class \"OCA\\News\\Controller\\FolderApiController\" does not exist","exception":[],"CustomMessage":"Class \"OCA\\News\\Controller\\FolderApiController\" does not exist"},"id":"65f036f019e90"}, {"reqId":"QR0Liwi05ez9diaNR1dO","level":3,"time":"2024-03-09T17:34:20+00:00","remoteAddr":"130.162.232.38","user":"--","app":"index","method":"GET","url":"/apps/richdocuments/settings/fonts.json","message":"Class \"OCA\\Richdocuments\\Controller\\FederationController\" does not exist","userAgent":"COOLWSD HTTP Agent 23.05.9.2","version":"29.0.0.7","exception":{"Exception":"ReflectionException","Message":"Class \"OCA\\Richdocuments\\Controller\\FederationController\" does not exist","Code":-1,"Trace":[{"file":"/var/www/html/lib/private/Route/Router.php","line":469,"function":"__construct","class":"ReflectionClass","type":"->","args":["OCA\\Richdocuments\\Controller\\FederationController"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":161,"function":"getAttributeRoutes","class":"OC\\Route\\Router","type":"->","args":["richdocuments"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":279,"function":"loadRoutes","class":"OC\\Route\\Router","type":"->","args":["richdocuments"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":330,"function":"findMatchingRoute","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/settings/fonts.json"]},{"file":"/var/www/html/lib/base.php","line":1050,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/richdocuments/settings/fonts.json"]},{"file":"/var/www/html/index.php","line":49,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/Route/Router.php","Line":469,"message":"Class \"OCA\\Richdocuments\\Controller\\FederationController\" does not exist","exception":[],"CustomMessage":"Class \"OCA\\Richdocuments\\Controller\\FederationController\" does not exist"},"id":"65f036f019f3e"} ]Additional info
I applied this patch without any effect.
I am absolutely aware that this version is tagged as
Beta. However it might be an actual bug, therefore reporting it here 😉The text was updated successfully, but these errors were encountered: