Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest name is not picked up the second time loading a share link #3865

Closed
juliusknorr opened this issue Aug 1, 2024 · 1 comment · Fixed by #3907
Closed

Guest name is not picked up the second time loading a share link #3865

juliusknorr opened this issue Aug 1, 2024 · 1 comment · Fixed by #3907
Assignees
Labels
1. to develop Waiting for a developer bug Something isn't working

Comments

@juliusknorr
Copy link
Member

As reported in the Collabora call:

Steps to reproduce

  1. Open a public share link
  2. Enter a name
  3. Reload the page

Actual behavior

No guest name picker, Showing up as anonymous guest, the cookie for guestName seems to be set

Expected behavior

No guest name picker, but the existing cookie is passed along properly to Collabora

@juliusknorr juliusknorr added bug Something isn't working 1. to develop Waiting for a developer labels Aug 1, 2024
@elzody elzody self-assigned this Aug 7, 2024
@juliusknorr
Copy link
Member Author

We could just pass the guest name along as parameter and get rid of using a cookie for that these days.

Then we can also just use nextcloud-libraries/nextcloud-auth#666 to store and obtain it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants