Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes reference widget #1167

Open
juliusknorr opened this issue Nov 20, 2023 · 7 comments · May be fixed by #1420
Open

Notes reference widget #1167

juliusknorr opened this issue Nov 20, 2023 · 7 comments · May be fixed by #1420
Assignees
Labels
1. to develop enhancement New feature or request

Comments

@juliusknorr
Copy link
Member

Would be nice to have an actual preview when pasting a note link:

Screenshot 2023-11-20 at 15 08 16
@juliusknorr juliusknorr added enhancement New feature or request 1. to develop labels Nov 20, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Oct 15, 2024
@JuliaKirschenheuter JuliaKirschenheuter moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Oct 15, 2024
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Oct 25, 2024

I've collected some examples regarding possible widgets:

  1. Image + text

Image

  1. Text

Image

  1. Image + text + user + last edit info

Image

  1. File preview + text

Image
Image

  1. Gif + text

Image

  1. Edit mode of existing internal document

Image

@JuliaKirschenheuter
Copy link
Contributor

Some examples which are not workable in other apps:

  1. Youtube (image)
    Image

  2. Code snippet form Github:

Image

  1. Any info from Github:

Image

@jancborchardt
Copy link
Member

@JuliaKirschenheuter in the popover widget (not the directly embedded one) the title is always duplicated, can we get rid of that?

(If it is needed as a placeholder until the actual widget loads that could be done but then replaced with the widget.)

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Oct 28, 2024
@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 28, 2024

As discussed via chat, the scope of this issue is to provide metadata for notes app links like https://nextcloud.local/apps/notes/note/12345 using the existing link preview API, so instead of the odd placeholder in the first post we'd show the note title somehow similar to linking a file maybe.

@jancborchardt Your comments seems a general text issue, maybe that can be filed separately (with a reference screenshot).

@nimishavijay
Copy link
Member

Thanks for the great screenshots of references @JuliaKirschenheuter ! Very helpful!

I would suggest it be like in Collectives, so (3) looks great. The image can be the file thumbnail. The text can be the name of the note on the first line, in [name of category] on the second line (if it is categorized), and last edited on the third line.

With the standardization of the widgets the specifics of the size, width, etc can be smoothed out in the other issue :)

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Oct 31, 2024

Seems that backend have to be implemented first. https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/reference.html#register-a-reference-provider (ReferenceProvider, PublicReferenceProvider) and https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/reference.html#using-the-default-widget for default widget (should be enough for current task).

@JuliaKirschenheuter JuliaKirschenheuter linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement New feature or request
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

Successfully merging a pull request may close this issue.

4 participants