-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to change the note path #1186
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
For those who really need a temporary workaround until this is fixed, you can update the path by doing the following:
This works because, upon modifying the value of "File extensions", Nextcloud Notes will send a request to the server to update all the settings to whichever values you set. |
Can confirm the workaround from @Benjamint22 has worked for me. |
Also confirm that the work-around from @Benjamint22 worked perfectly! By the way, as a little bit of input for whomever will review this, prior to trying the work-around, I had tried to make changes via OCC commands (instead of via web gui)...and even THAT failed to work...But its failure was interesting ...Here's what I mean... I ran the following via the command line in order to make the desired changes to defaults for the Notes app:
I received "success" sorts of responses. So, then I ran the following command to see what values were actually saved under the Notes' app's config - just you know in case, to verify things:
Well, the output showed that that my adjustments via the OCC were in fact saved/preserved, and shown in a json format! Meaning that somehow OCC reports that my new desired values are saved...but, the Notes app still did not "see" the new/adjusted values...So, maybe a misconnect between some OCC config and whatever config store the Notes app actually uses? I would guess the good work-around communicated by @Benjamint22 seems to bypass this bug between OCC and the Notes app's config store...i assume...since the work-around worked for me. Hoping this minor clue helps any of the Devs in their investigation! |
Maybe an interesting information to the devs: |
Indeed, the The other .js files doesn't seem to be a problem as their importation is made directly from the requested page, their resolution point correctly to "custom_apps". Wouldn’t the problem then come from the build step? resolving the path wrongly ? I think a way to reproduce this error is to:
'apps_paths' =>
array (
0 =>
array (
'path' => '/var/www/html/apps',
'url' => '/apps',
'writable' => false,
),
1 =>
array (
'path' => '/var/www/html/custom_apps',
'url' => '/custom_apps',
'writable' => true,
),
), and create the directory:
|
I was able to fix this issue by adding the next line to the __webpack_public_path__ = getAppRootUrl("notes") + '/js/'; Don't know if it's a real solution or just a hack. See webpack documentation about it Just saw the line |
@OrIOg Indeed. That seems right (of several variations that should work similarly). Thanks for looking into this you all. :) I do believe this has since been fixed in the main (dev) branch via 582414f as part of some other work. Manual backport pending in #1341. Can you test that variation in your environment to make sure it behaves as you'd expect to address this issue? |
I tested the fix using the branch "stable4.10" on Nextcloud(AIO): 29.0.2.2 with Firefox128.0.3 (64-bit), We can now change the path. Although another problem appear, if the used note path doesn't contain the forward-slash at the start so the It seems to be easily fixed this line: notes/src/components/AppSettings.vue Line 165 in 4b811ef
to event.target.value === '' ? '/' : `/${event.target.value}`, // path or something equivalent. Should I create a new issue or make pull-request to fix this referencing this issue ? |
Either fine, but PR preferred. :-) |
I'm unable to change the note path. I can enter a new path in the settings, but as soon as I create a new note, or close the Notes app, the setting reverts back to the default path.
Steps to reproduce
Or:
Expected behaviour
The new setting should stick and new notes should be created in the "Test" folder.
Actual behaviour
As explained above.
Server
Please complete the following information.
Client
Please complete the following information.
Log files
This is from the browser console when clicking on the notes path text box in the settings:
Content-Security-Policy: The page’s settings blocked the loading of a resource at https://XXXXX/apps/notes/js/notes-commons.js?v=bd34eeaf039b6bffcb57 (“script-src”). notes-main.js:2:4211446
Uncaught (in promise) ChunkLoadError: Loading chunk 351 failed.
(error: https://XXXXX/apps/notes/js/notes-commons.js?v=bd34eeaf039b6bffcb57)
j https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
e https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
e https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
pick https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
onChangeNotePath https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
yn https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
n https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
_wrapper https://XXXXX/apps/notes/js/notes-main.js?v=11bfdcc7-0:2
notes-main.js:2:4211921
The text was updated successfully, but these errors were encountered: