Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor FilesBloc initial path #568

Closed
Leptopoda opened this issue Aug 15, 2023 · 1 comment · Fixed by #780
Closed

refactor FilesBloc initial path #568

Leptopoda opened this issue Aug 15, 2023 · 1 comment · Fixed by #780
Labels
good first issue Good for newcomers package: files_app Neon files implementation refactoring Something that needs to be refactored

Comments

@Leptopoda
Copy link
Member 

          I know you didn't introduce this code, but could you make it so that it is possible to pass an optional initial path to the files browser bloc instead of having to call setPath directly after it?

Originally posted by @provokateurin in #556 (comment)
@Leptopoda Leptopoda added good first issue Good for newcomers package: files_app Neon files implementation refactoring Something that needs to be refactored labels Aug 15, 2023
@provokateurin provokateurin added this to the Nextcloud Conference Hackathon milestone Aug 18, 2023
@Leptopoda Leptopoda mentioned this issue Aug 25, 2023
Draft
3 tasks
@Leptopoda
Copy link
Member Author 

          I hate all the path handling.

I was thinking to write a custom FilesUri class that implements uri and gives us these features (like removing trailing /, joining path + filename ...

What do you think? This is more a general question that would fit with #568

Originally posted by @Leptopoda in #600 (comment)

@provokateurin provokateurin mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers package: files_app Neon files implementation refactoring Something that needs to be refactored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(neon_files): Allow setting an intial path for files browser bloc nextcloud/neon
2 participants
@Leptopoda @provokateurin