From 831be1df415686df90e7920811759239ff373aa7 Mon Sep 17 00:00:00 2001
From: hamza221 <hamzamahjoubi221@gmail.com>
Date: Mon, 7 Aug 2023 12:48:32 +0200
Subject: [PATCH] fixup! add thread summary ui

Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
---
 lib/Controller/SettingsController.php |  1 +
 lib/Controller/ThreadController.php   | 14 ++++++--------
 src/components/LoadingSkeleton.vue    |  2 +-
 src/components/Thread.vue             | 21 ++++++++++++++++-----
 src/service/AiIntergrationsService.js | 11 ++++++++---
 src/service/SettingsService.js        |  3 ++-
 6 files changed, 34 insertions(+), 18 deletions(-)

diff --git a/lib/Controller/SettingsController.php b/lib/Controller/SettingsController.php
index a742eda9d8..827d3aa681 100644
--- a/lib/Controller/SettingsController.php
+++ b/lib/Controller/SettingsController.php
@@ -119,6 +119,7 @@ public function deleteAntiSpamEmail(): JSONResponse {
 	public function setAllowNewMailAccounts(bool $allowed) {
 		$this->config->setAppValue('mail', 'allow_new_mail_accounts', $allowed ? 'yes' : 'no');
 	}
+
 	public function setEnabledThreadSummary(bool $enabled) {
 		$this->config->setAppValue('mail', 'enabled_thread_summary', $enabled ? 'yes' : 'no');
 	}
diff --git a/lib/Controller/ThreadController.php b/lib/Controller/ThreadController.php
index 6fa5ade9cc..87cfd22576 100755
--- a/lib/Controller/ThreadController.php
+++ b/lib/Controller/ThreadController.php
@@ -44,16 +44,14 @@ class ThreadController extends Controller {
 	private LoggerInterface $logger;
 
 
-	public function __construct(string                $appName,
-		IRequest              $request,
-		string                $UserId,
-		AccountService        $accountService,
-		IMailManager          $mailManager,
+	public function __construct(string $appName,
+		IRequest $request,
+		string $UserId,
+		AccountService $accountService,
+		IMailManager $mailManager,
 		AiIntegrationsService $aiIntergrationsService,
-		LoggerInterface       $logger,
-	) {
+		LoggerInterface $logger) {
 		parent::__construct($appName, $request);
-
 		$this->currentUserId = $UserId;
 		$this->accountService = $accountService;
 		$this->mailManager = $mailManager;
diff --git a/src/components/LoadingSkeleton.vue b/src/components/LoadingSkeleton.vue
index 4ea521b75b..0a6aefb402 100644
--- a/src/components/LoadingSkeleton.vue
+++ b/src/components/LoadingSkeleton.vue
@@ -1,7 +1,7 @@
 <template>
 	<div>
 		<div v-for="i in numberOfLines" :key="i" class="item-list__entry">
-			<div
+			<div v-if="withAvatar"
 				class="item-avatar" />
 			<div class="item__details">
 				<h3>&nbsp;</h3>
diff --git a/src/components/Thread.vue b/src/components/Thread.vue
index 6008ce9035..a0468948ec 100644
--- a/src/components/Thread.vue
+++ b/src/components/Thread.vue
@@ -38,7 +38,7 @@
 					</div>
 				</div>
 			</div>
-			<ThreadSummary v-if="thread.length > 2 && enabledThreadSummary" :loading="summaryLoading" :summary="summaryText" />
+			<ThreadSummary v-if="showSummaryBox" :loading="summaryLoading" :summary="summaryText" />
 			<ThreadEnvelope v-for="env in thread"
 				:key="env.databaseId"
 				:envelope="env"
@@ -55,6 +55,7 @@
 
 <script>
 import { NcAppContentDetails as AppContentDetails, NcPopover as Popover } from '@nextcloud/vue'
+import { showError } from '@nextcloud/dialogs'
 
 import { prop, uniqBy } from 'ramda'
 import debounce from 'lodash/fp/debounce'
@@ -99,6 +100,7 @@ export default {
 			resizeDebounced: debounce(500, this.updateParticipantsToDisplay),
 			enabledThreadSummary: loadState('mail', 'enabled_thread_summary', false),
 			summaryText: '',
+			summaryError: false,
 		}
 	},
 
@@ -148,6 +150,9 @@ export default {
 			}
 			return thread[0].subject || this.t('mail', 'No subject')
 		},
+		showSummaryBox() {
+			return this.thread.length > 2 && this.enabledThreadSummary && !this.summaryError
+		},
 	},
 	watch: {
 		$route(to, from) {
@@ -173,12 +178,18 @@ export default {
 	},
 	methods: {
 		async updateSummary() {
-			if (this.thread.length < 2 && !this.enabledThreadSummary) return
+			if (this.thread.length < 2 || !this.enabledThreadSummary) return
 
 			this.summaryLoading = true
-			const summary = await summarizeThread(this.thread[0].databaseId)
-			this.summaryText = summary
-			this.summaryLoading = false
+			try {
+				this.summaryText = await summarizeThread(this.thread[0].databaseId)
+			} catch (error) {
+				this.summaryError = true
+				showError(t('mail', 'Summarizing thread failed.'))
+				logger.error('Summarizing thread failed',{ error})
+			} finally {
+				this.summaryLoading = false
+			}
 		},
 		updateParticipantsToDisplay() {
 			// Wait until everything is in place
diff --git a/src/service/AiIntergrationsService.js b/src/service/AiIntergrationsService.js
index 0829e58026..a1c7443200 100644
--- a/src/service/AiIntergrationsService.js
+++ b/src/service/AiIntergrationsService.js
@@ -1,11 +1,16 @@
 import { generateUrl } from '@nextcloud/router'
 import axios from '@nextcloud/axios'
+import { convertAxiosError } from '../errors/convert'
 
-export const summarizeThread = async (threadId, accountId) => {
+export const summarizeThread = async (threadId) => {
 	const url = generateUrl('/apps/mail/api/thread/{threadId}/summary', {
 		threadId,
 	})
 
-	const resp = await axios.get(url)
-	return resp.data.data
+	try {
+		const resp = await axios.get(url)
+		return resp.data.data
+	} catch (e) {
+		throw convertAxiosError(e)
+	}
 }
diff --git a/src/service/SettingsService.js b/src/service/SettingsService.js
index 37c873d24c..6eb92d814a 100644
--- a/src/service/SettingsService.js
+++ b/src/service/SettingsService.js
@@ -82,5 +82,6 @@ export const updateEnabledThreadSummary = async (enabled) => {
 	const data = {
 		enabled,
 	}
-	return await axios.post(url, data).then((resp) => resp.data)
+	const resp = await axios.post(url, data)
+	return resp.data
 }