*Download logs* shown to sub admin, results in unhandled 403

[ChristophWurst]

Steps to reproduce

1. Set up nextcloud with sub admins
2. Log in as sub admin
3. Open the logging settings
4. See and click Download logs

Expected behaviour

Either I don't see the button or it works

Actual behaviour

The button is clickable and a XHR to /settings/admin/log/download is sent. It results in a HTTP 403 with no UI or console handling.

Server configuration

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: 30

Where did you install Nextcloud from:

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Client configuration

Browser:

Operating system:

Logs

Nextcloud log (data/owncloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

[joshtrichards]

I wonder if we should move download from server to logreader while we're at it?

https://github.com/nextcloud/server/blob/0801ef8bcd0a2aa3e4e9ffd29212415a909a1331/apps/settings/lib/Controller/LogSettingsController.php#L37

https://github.com/nextcloud/server/blob/0801ef8bcd0a2aa3e4e9ffd29212415a909a1331/apps/settings/appinfo/routes.php#L46

I guess it depends a bit on whether there is anything else using it that we don't want to be dependent on logreader for some reason. 🤔