Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Form Creation & Sharing Settings #1199

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 8, 2022

grafik
grafik

Implements #647 and #922

@jotoeri jotoeri marked this pull request as draft May 8, 2022 12:00
@jotoeri jotoeri changed the title Restrict Form Creation Restrict Form Creation & Sharing Settings May 8, 2022
@jotoeri jotoeri added enhancement New feature or request 2. developing Work in progress labels May 8, 2022
src/Forms.vue Show resolved Hide resolved
@jotoeri jotoeri force-pushed the enh/restrict_creation branch 10 times, most recently from 67031b9 to 5055c2a Compare May 8, 2022 16:01
@jotoeri jotoeri added this to the 3.0 milestone May 8, 2022
@jotoeri jotoeri force-pushed the enh/restrict_creation branch from 34ca767 to 3eececa Compare May 8, 2022 17:00
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #1199 (4893065) into master (2e78fc2) will increase coverage by 1.46%.
The diff coverage is 58.25%.

❗ Current head 4893065 differs from pull request most recent head a150a22. Consider uploading reports for the commit a150a22 to get more accurate results

@@             Coverage Diff              @@
##             master    #1199      +/-   ##
============================================
+ Coverage     31.62%   33.09%   +1.46%     
- Complexity      432      466      +34     
============================================
  Files            40       44       +4     
  Lines          1698     1798     +100     
============================================
+ Hits            537      595      +58     
- Misses         1161     1203      +42     

@jotoeri jotoeri force-pushed the enh/restrict_creation branch 5 times, most recently from affb5a2 to eaa84b2 Compare May 9, 2022 22:11
@jotoeri
Copy link
Member Author

jotoeri commented May 9, 2022

Waiting for

@jotoeri jotoeri force-pushed the enh/restrict_creation branch from eaa84b2 to 101f96f Compare May 23, 2022 20:32
@jotoeri jotoeri force-pushed the fix/apiv2 branch 2 times, most recently from 170df20 to e042efa Compare May 24, 2022 09:00
@jotoeri jotoeri added the 3. to review Waiting for reviews label Jun 3, 2022
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any problems running this code in my local instance :)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! :) Just some wording feedback

src/FormsSettings.vue Outdated Show resolved Hide resolved
src/FormsSettings.vue Outdated Show resolved Hide resolved
src/FormsSettings.vue Outdated Show resolved Hide resolved
src/FormsSettings.vue Outdated Show resolved Hide resolved
src/FormsSettings.vue Outdated Show resolved Hide resolved
src/FormsSettings.vue Outdated Show resolved Hide resolved
@jotoeri jotoeri force-pushed the enh/restrict_creation branch 3 times, most recently from bfe509e to c4474fa Compare June 26, 2022 22:03
@jotoeri
Copy link
Member Author

jotoeri commented Jun 26, 2022

Good stuff! :) Just some wording feedback

Everything fixed. 🙂

Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more "users" in the texts. Adjust right now or create a PR to change all occurrences at once?

src/components/SidebarTabs/SharingSidebarTab.vue Outdated Show resolved Hide resolved
src/components/SidebarTabs/SharingSidebarTab.vue Outdated Show resolved Hide resolved
@jotoeri jotoeri force-pushed the enh/restrict_creation branch 2 times, most recently from 6722519 to 162bb07 Compare June 27, 2022 19:55
jotoeri added 4 commits July 1, 2022 16:59
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
Signed-off-by: Jonas Rittershofer <[email protected]>
@jotoeri jotoeri force-pushed the enh/restrict_creation branch from 4893065 to a150a22 Compare July 1, 2022 15:00
@jotoeri jotoeri added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 1, 2022
@jotoeri jotoeri merged commit c5d0ed7 into master Jul 1, 2022
@jotoeri jotoeri deleted the enh/restrict_creation branch July 1, 2022 15:49
@Tom5421
Copy link

Tom5421 commented Aug 8, 2022

Is this available in the Forms app yet, I have the app but I can't see this screen in the settings page

@jotoeri
Copy link
Member Author

jotoeri commented Aug 8, 2022

Hey Tom, it is not available yet, we're currently on the last mile to prepare for a release. However don't expect a fix eta, it might still take up to a few weeks. 😉

@greavette
Copy link

Hi Team,

I'm very happy to see this new feature being worked on. In my use case, it would allow Admins to create the Form and have our general users who don't need to create Forms to be able to complete the forms Admin assigns to them.

Is there a date when this feature will be released?

Thank you.

@jotoeri
Copy link
Member Author

jotoeri commented Jan 31, 2023

Hey @greavette, this is available already in Forms >=v3. We had unfortunately to restrict the support of v3 to Nextcloud >=25, so once you update to NC25 & Forms v3 you can use this.

@greavette
Copy link

Hello @jotoeri , Appreciate the reply! I'm using Forms version 3.04 on Nextcloud version 25.03

I've tried testing this but could not get this to work. Please assist with what I'm doing incorrectly.

Mary has a limited account on our NextCloud (Not Admin). She does not have access to Forms.
I'm the Admin and I created a Form for Mary to complete. I shared this form with Mary.

When I log in to Mary's Nextcloud I don't see the form I shared with her.

Am I misunderstanding how this works? My expectation was that I could create a form for Mary to complete, Mary would see the form and complete it and send it back to me for review. Once Mary has completed the form I will unshare and keep the results for historical purposes.

What am I missing? Thank you.

@jotoeri
Copy link
Member Author

jotoeri commented Feb 13, 2023

Hey @greavette
generally it sounds like your understanding of the feature is right. I currently cant fully track, what you did, but maybe you disabled the app by the app-management?
For this feature to work, you must enable the app for all users within your nextcloud and then you find within the admin-settings a section for forms and the point to restrict form-creation to groups.

If that does not help, please head over to the forum https://help.nextcloud.com for further support, since we cant provide support here on github.

Greets,
Jonas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to select which sharing options should be made available Only form creation for admins
5 participants