Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission notification email needs a plural form as multiple users can be present in {user} #2434

Open
Mer0me opened this issue Nov 26, 2024 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working language l10n and translations

Comments

@Mer0me
Copy link

Mer0me commented Nov 26, 2024

Please use the 👍 reaction to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug
When multiples users have answered to a form since the last notification email, we receive a mail notification saying "user1 and user2 answered your form". In french translation of this sentence, there is a grammar error. This cannot be fixed in transifex because no plural form is available for this sentence.

To Reproduce
Steps to reproduce the behavior:

  1. User1 fills a form
  2. User2 fills the same form
  3. Form owner receives a notification mail with grammar error.

Expected behavior
Notification mails should be correct grammatically (in french !).

Screenshots
Image
"a répondu" should be "ont répondu"

Nextcloud (please complete the following information):

  • Nextcloud-Version: 30.0.2
  • Forms-Version: 4.3.4

Source ref :

return $l10n->t('{user} answered your form {formTitle}');

cc @rakekniven

@Mer0me Mer0me added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Nov 26, 2024
@rakekniven
Copy link
Member

Plural is needed for german as well.

@Chartman123
Copy link
Collaborator

How about switching this string to passive? 'Your form {formTitle} was answered by {user}'

@Chartman123 Chartman123 added 1. to develop Accepted and waiting to be taken care of language l10n and translations and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 26, 2024
@rakekniven
Copy link
Member

In german it helps as well. Not sure about the languages we support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working language l10n and translations
Projects
None yet
Development

No branches or pull requests

3 participants