Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageMagick in CI environment to support HEIF/HEIC test cases #102

Open
steiny2k opened this issue Aug 15, 2018 · 1 comment
Open

Comments

@steiny2k
Copy link

Steps to reproduce

  1. Submit a pullrequest like Support HEIC for previews server#10526 which requires a recent version of ImageMagick convert tool
  2. CI test case fails: https://drone.nextcloud.com/nextcloud/server/9604

Expected behaviour

Test case should report green.
grafik

Actual behaviour

Due to the version of ImageMagick which lacks support to read HEIF/HEIC files (the new Apple file format for iPhones) in the CI environment, the test case fails (see log below).

Server configuration

Running the tests on macOS with ImageMagick 7.0.8-9 installed through Homebrew works:
brew install --with-libheif imagemagick

Operating system:
macOS 10.13.6

Web server:
embedded php webserver

Database:
embedded sqlite

PHP version:
7.2

Nextcloud version: (see Nextcloud admin page)
github master checkout

Updated from an older Nextcloud/ownCloud or fresh install:
new install

Where did you install Nextcloud from:
github

Logs

CI log (data/nextcloud.log)

Nextcloud CI log (https://drone.nextcloud.com/nextcloud/server/9604)
1) Test\Preview\HEICTest::testGetThumbnail with data set #0 (-85, -61)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

2) Test\Preview\HEICTest::testGetThumbnail with data set #1 (34, 26)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

3) Test\Preview\HEICTest::testGetThumbnail with data set #2 (-76, 55)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103

4) Test\Preview\HEICTest::testGetThumbnail with data set #3 (75, -84)
Failed asserting that false is not equal to false.

/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:141
/drone/src/github.com/nextcloud/server/tests/lib/Preview/Provider.php:103
@steiny2k
Copy link
Author

This is a duplicate of nextcloud/server#10668 which I think could be closed. This is probably the better place to raise this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant