Improve read only virtual files support on Windows #7477
+31
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure that even if move to trash is enabled, we do not erroneously try to move online only files or folders to trash bin Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
we need to make shortcut files be proper virtual placeholder files let the sync engine use the proper item type for that Signed-off-by: Matthieu Gallien <[email protected]>
we cannot do a single call to convert the plain old file to be a dehydrated virtual file placeholder split the conversion into a separate initial API call fix transition from releases < 3.14 to current releases that have first class support for windows shortcuts (so called link files) Signed-off-by: Matthieu Gallien <[email protected]>
should make the existing log more useful when tracking the self requested implicit hydration bugs Signed-off-by: Matthieu Gallien <[email protected]>
we were using specialized API to set the file permissions on the windows shortcut and later falling back to the generic code path due to the mising return Signed-off-by: Matthieu Gallien <[email protected]>
will prevent some type of activity being added to the list from triggering implicit hydration during synchronization most probably breaks existing open actions on those activities Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
change the way we evaluate a folder permissions to be read-only when no new file or new folders can be created if those permissions are lacking, client will make the local folder read-only if those permissions are granted, client will make local folder read-write Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/readOnlyVirtualFilesFixes
branch
from
45284a6
to
a77f1b1
Compare
8 tasks
|
AppImage file: nextcloud-PR-7477-a77f1b106438bfc9a3a486bfbd5b91d926b61805-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.