Text strings for 2, 3, and 4

[Valdnet]

Add text strings for the number of items for the numbers 3, 4, and 5 in the following text strings:

desktop/src/gui/userstatusselectormodel.cpp

Line 417 in 06f3723

return tr("%1 minutes").arg(minutesLeft);

desktop/src/gui/userstatusselectormodel.cpp

Line 424 in 06f3723

return tr("%1 hours").arg(hoursLeft);

desktop/src/gui/userstatusselectormodel.cpp

Line 431 in 06f3723

return tr("%1 days").arg(daysLeft);

This change is significant for various languages, e.g. in Polish it is as follows:

1 minuta
2 minuty
3 minuty
4 minuty
5 minut

[mgallien]

is it not a limitation of using tr ?
I guess KI18n framework from KDE's community is working fine for this (at least I know that translators of French are then able to select the correct form).
could you have a look to see how well it is working for Polish ?

[Valdnet]

@mgallien For other text strings, it is possible to translate both singular and plural.
Sample text string:

desktop/src/common/utility.cpp

Lines 503 to 506 in 06f3723

	} else if (minutes == 1) {
	return (QObject::tr("%n minute ago", "", minutes));
	} else {
	return (QObject::tr("%n minutes ago", "", minutes));

However, for the above-mentioned strings, this is not possible. This is probably due to the code.

[mgallien]

@Valdnet do you want to work on a patch ?
I am a bit short on the time available to do it myself in a reasonable time frame

[Valdnet]

do you want to work on a patch ?

I could, but the change probably requires more coding knowledge.

[Valdnet]

@mgallien Sample of code change:

        if (minutesLeft == 1) {
            return tr("%1 minute", "", minutesLeft);
        } else {
            return tr("%1 minutes", "", minutesLeft);
        }

Is my logic right? Do I need to improve anything else?

[mgallien]

@Valdnet yes but in this case should you not also add context to help translators ?

[Valdnet]

@mgallien Well. I will take care of this and add context for the translators.

[Valdnet]

Changes made.

@mgallien Please check if it's okay. I did not add context for the translators because they are simple text strings that do not require detailed explanation for their meanings.

[Rello]

this can not be implemented for technical reasons