Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate comments on files in the file browser #232

Closed
jospoortvliet opened this issue Mar 27, 2018 · 2 comments
Closed

Integrate comments on files in the file browser #232

jospoortvliet opened this issue Mar 27, 2018 · 2 comments
Assignees
Labels
design enhancement enhancement of a already implemented feature/code integration

Comments

@jospoortvliet
Copy link
Member

Would be nice if a file had comments on it, a special icon would show and users could see the comment and comment themselves on files, too!

@jospoortvliet jospoortvliet added design enhancement enhancement of a already implemented feature/code integration labels Mar 27, 2018
@jancborchardt
Copy link
Member

Hehe, I see you read my other issue comments. ;)

Yes, this would indeed be nice. I’m wondering if this is possible since there might be a limit on how many different icons we can register, if I remember correctly?

Design-wise yes, we could simply show the icon-comment over the file. And in the right-click menu we can show it where the »Share« entry is also shown.

And this does not need to be a separate window – it can be the same window as we use for sharing already. Basically it should mimick the right sidebar in Files (with 2 tabs: Activity [including comments and versions] and Sharing):
screenshot from 2018-03-27 22-04-07

@camilasan camilasan added this to the 2.5.5 🌟 UI improvements milestone Aug 12, 2019
@misch7 misch7 modified the milestones: 2.7 🌟 UI improvements, 3.0 🥚 Jun 10, 2020
@mgallien mgallien removed this from the 4.0 🥚 milestone Sep 8, 2021
@Rello
Copy link
Contributor

Rello commented Nov 8, 2024

The client has improved a lot since the ticket was opened.
If it is still relevant, please create a fresh ticket.
Thank you for your support

@Rello Rello closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement enhancement of a already implemented feature/code integration
Projects
None yet
Development

No branches or pull requests

6 participants