Illegal use of server 3rdparty (symfony/event-dispatcher)

[nickvergessen]

This app is directly using classes of the symfony/event-dispatcher package in server. Please migrate to the official OCP wrappers.

[mejo-]

Thanks for raising this @nickvergessen.

In CacheListener.php this is pretty straight-forward. Just replace Symfony\Component\EventDispatcher\EventDispatcher with OCP\EventDispatcher\IEventDispatcher.

But in Versions/CollectiveVersionsExpireManager.php I'm not sure about the solution. new User() expects Symfony\Component\EventDispatcher\EventDispatcherInterface as argument, and IEventDispatcher doesn't provide that.

[nickvergessen]

Might be needed that server is modified before this. But not entirely sure.

[max-nextcloud]

Thanks for raising this @nickvergessen.

In CacheListener.php this is pretty straight-forward. Just replace Symfony\Component\EventDispatcher\EventDispatcher with OCP\EventDispatcher\IEventDispatcher.

But in Versions/CollectiveVersionsExpireManager.php I'm not sure about the solution. new User() expects Symfony\Component\EventDispatcher\EventDispatcherInterface as argument, and IEventDispatcher doesn't provide that.

Are both these cases covered with the PR that closed the issue?

[nickvergessen]

But in Versions/CollectiveVersionsExpireManager.php I'm not sure about the solution. new User() expects Symfony\Component\EventDispatcher\EventDispatcherInterface as argument, and IEventDispatcher doesn't provide that.

nextcloud/server#39595 has you covered... Or well that creates the problem for you. But now you can give it IEventDispatcher.

[max-nextcloud]

Checked in with jonas and the two aspects were addressed separately - one with the commits listed above on Jun 5 and the linked PR above just addressed what was left afterwards.