Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.0-beta.1 Compatibility with NC 25.0 #227

Open
Bockeman opened this issue Dec 7, 2022 · 27 comments
Open

v1.1.0-beta.1 Compatibility with NC 25.0 #227

Bockeman opened this issue Dec 7, 2022 · 27 comments
Labels
info: Pinned type: Support

Comments

@Bockeman
Copy link

Bockeman commented Dec 7, 2022

When I attempt to update NC as follows:

sudo -u apache php /var/www/html/nextcloud/updater/updater.phar \
  Nextcloud Updater - version: v25.0.0beta3-17-gef6cf2d
  
  Current version is 25.0.0.
  
  Update to Nextcloud 25.0.2 RC3 available. (channel: "beta")
  Following file will be downloaded automatically: https://download.nextcloud.com/server/prereleases/nextcloud-25.0.2rc3.zip
  ...

It produces a stack dump as follows:

  Repair info: Syncing Pico CMS app data folder ?
  An unhandled exception has been thrown:
  TypeError: OC\Files\Utils\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\Log\LoggerInterface, OC\Log given, called in /extra/www/html/verivault/apps/cms_pico/lib/Files/StorageFolder.php on line 204 and defined in /extra/www/html/verivault/lib/private/Files/Utils/Scanner.php:95
  Stack trace:
  #0 /extra/www/html/verivault/apps/cms_pico/lib/Files/StorageFolder.php(204): OC\Files\Utils\Scanner->__construct(NULL, Object(OC\DB\ConnectionAdapter), Object(OC\EventDispatcher\EventDispatcher), Object(OC\Log))
  #1 /extra/www/html/verivault/apps/cms_pico/lib/Service/FileService.php(186): OCA\CMSPico\Files\StorageFolder->sync(false)
  #2 /extra/www/html/verivault/apps/cms_pico/lib/Migration/AppDataRepairStep.php(170): OCA\CMSPico\Service\FileService->syncAppDataFolder()
  #3 /extra/www/html/verivault/apps/cms_pico/lib/Migration/AppDataRepairStep.php(140): OCA\CMSPico\Migration\AppDataRepairStep->syncAppDataFolder()
  #4 /extra/www/html/verivault/lib/private/Repair.php(127): OCA\CMSPico\Migration\AppDataRepairStep->run(Object(OC\Repair))
  #5 /extra/www/html/verivault/lib/private/legacy/OC_App.php(1064): OC\Repair->run()
  #6 /extra/www/html/verivault/lib/private/Installer.php(156): OC_App::executeRepairSteps('cms_pico', Array)
  #7 /extra/www/html/verivault/core/Command/App/Enable.php(111): OC\Installer->installApp('cms_pico', false)
  #8 /extra/www/html/verivault/core/Command/App/Enable.php(81): OC\Core\Command\App\Enable->enableApp('cms_pico', Array, false, Object(Symfony\Component\Console\Output\ConsoleOutput))
  #9 /extra/www/html/verivault/3rdparty/symfony/console/Command/Command.php(255): OC\Core\Command\App\Enable->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
  #10 /extra/www/html/verivault/3rdparty/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
  #11 /extra/www/html/verivault/3rdparty/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(OC\Core\Command\App\Enable), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
  #12 /extra/www/html/verivault/3rdparty/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
  #13 /extra/www/html/verivault/lib/private/Console/Application.php(213): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
  #14 /extra/www/html/verivault/console.php(100): OC\Console\Application->run()
  #15 {main}
  ...

I can work around this by stepping back to v1.0.19 and editing the max-version to 25.
Either way an update to v1.0.19 should be released is compatible with NC25, or the v1.1.0-beta.1 is updated with genuine compatibility with NC.
@PhrozenByte
Copy link
Collaborator

Upgrade to v1.0.21, this version is compatible with Nextcloud 25.

@Bockeman
Copy link
Author

Bockeman commented Dec 9, 2022 •
edited
Loading

@PhrozenByte thanks very much for responding.
Agreed, v1.0.21 is compatible with NC25, so no problem there.

But I have "Beta" set for my NC upgrades (dangerous I know, but I do thorough backups and wind back if I cannot workaround any problems).

Beta means that v1.1.0-beta.1 is seen as the latest available version, and whenever I do an NC upgrade, it wants to and does pick that (which I'm trying to workaround). Because v1.1.0-beta.1 is not compatible, that creates the mess which is the subject of this issue.

Now what I don't know is whether this is a bug in the NC upgrade mechanism (it should not pick an incompatible app version) or whether there is a deficiency in how v1.1.0-beta.1 presents itself to NC upgrade. Perhaps you can help.

However, my suggestions would be

  1. Remove or rename v1.1.0-beta.1 so that NC Beta upgrade cannot this version.
  2. Fix the max_version in v1.1.0-beta.1 as I do successfully with
    sed -i 's/"24"/"25"/' /var/www/html/verivault/apps/cms_pico/appinfo/info.xml
    (that works, but it does not solve the NC upgrade stack dump problem)
  3. Upgrade the beta version to something which is genuinely NC 25 compatible.

@Bockeman Bockeman mentioned this issue Dec 10, 2022
Open
9 tasks
@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman
Copy link
Author

Is this likely to get looked at?

However, my suggestions would be

1. Remove or rename v1.1.0-beta.1 so that NC Beta upgrade cannot this version.
2. Fix the max_version in v1.1.0-beta.1 as I do successfully with
`sed -i 's/"24"/"25"/' /var/www/html/verivault/apps/cms_pico/appinfo/info.xml`
(that works, but it does not solve the NC upgrade stack dump problem)
3. Upgrade the beta version to something which is genuinely NC 25 compatible.

@PhrozenByte
Copy link
Collaborator

Not in the short term I'm afraid. It should fix itself when publishing the final v1.1 resp v2.0 and I might find some time over the holidays to publish these new versions, but no guarantees given.

@Bockeman
Copy link
Author

@PhrozenByte that's great. What I really wanted to avoid was this issue being marked as "stale". But so good to hear this is likely to be resolved in the not too distant future.

@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@PhrozenByte
Copy link
Collaborator

This will be fixed no matter whether this issue is kept open or not, simply because this issue doesn't really track something - it will be fixed automatically with a final release. So, no worries if the bot closes this issue @Bockeman 👍

@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@Bockeman
Copy link
Author

I upgraded to Nexcloud 25.0.3.
I'm using 1.0.21 as a stop-gap until things get fixed properly.
The NextCloud error logging page is littered with debug messages every one second:

  Debug	cms_pico	/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.	  2023-01-20T16:51:05+0000
  Debug	cms_pico	/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.	  2023-01-20T16:51:05+0000
  Debug	cms_pico	/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.	  2023-01-20T16:51:04+0000
  Debug	cms_pico	/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.	  2023-01-20T16:51:04+0000
  Debug	cms_pico	/appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.	  2023-01-20T16:51:04+0000
  ...
  ...
  ...

I'm reluctant to report this as a bug because clearly I am picking up a possibly incompatible version, but will do if you advise @PhrozenByte.
(and in any cases, debug messages repeated every second are surely going to cause other problems)

@PhrozenByte
Copy link
Collaborator

@Bockeman Disable debug mode resp. increase the log level accordingly.

@Bockeman
Copy link
Author

@PhrozenByte thanks for the tip (I had to double check the documentation -- for some reason in my mind I had thought decreasing 'loglevel' decreased the logging verbosity, but in fact, as you say, I need to increase loglevel. Done).

@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman
Copy link
Author

Bockeman commented Feb 6, 2023

This now applies to NC 26.0
@PhrozenByte can you tell me anything that might raise my hopes for a fix/resolution?

@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@Bockeman

This comment was marked as outdated.

Sign in to view
@enrauk
Copy link

enrauk commented Oct 23, 2023

This now applies to NC27.0, is this still going to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info: Pinned type: Support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PhrozenByte @Bockeman @enrauk