FileDownloadWorker and TwoWaySync Notification

[alperozturk96]

⚠️ Before posting ⚠️

• This is a bug, not a question or an enhancement.
• I've searched for similar issues and didn't find a duplicate.
• I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
• I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

1. Set up the folder for two-way sync.
2. Wait until the sync is complete.

Expected behaviour

1. Notifications should not get stuck at 100%.
2. Notifications should reflect actual progress and not jump to 100% when progress is lower.
3. Empty notifications should not appear at all.

Actual behaviour

Notifications occasionally get stuck at 100% and do not reflect actual progress. Empty notifications may also appear, along with intermittent blinking.

Technical Explanation

The FileDownloadWorker can be triggered for each file or folder. Typically, it is initiated by individual files, meaning that a new worker starts for each file or folder. This can lead to issues with notifications, such as blinking, inaccurate progress and difficulty tracking current and total download counts.

FileDownloadWorker uses a static IndexedForest() to track each download’s status, enabling the display of sync, tick, and cancel icons in adapters. This complex data type is paired with Vector() to add a DownloadDataTransferProgressListener and notify LocalBroadcastManager. This approach is overly complex and can be unreliable.

Suggested Solution

Separate the FileDownloadWorker into two distinct workers: one for folders and one for individual files. Simplify the data structure by removing unnecessary complexity.

Android version

15

Device brand and model

Android Emulator

Stock or custom OS?

Stock

Nextcloud android app version

3.30.3

Nextcloud server version

29.0.4