Unused keys in container shema

[docjyJ]

Steps to reproduce

1. In file, https://github.com/nextcloud/all-in-one/blob/main/php/containers-schema.json: ctrl+f > cap_drop, profiles, user, networks or expose
2. In file, https://github.com/nextcloud/all-in-one/blob/main/php/src/ContainerDefinitionFetcher.php: ctrl+f > cap_drop, profiles, user, networks or expose
3. They are defined but never used...

all-in-one/php/containers.json

Lines 73 to 75 in 267aebf

	"cap_drop": [
	"NET_RAW"
	]

Expected behavior

Actual behavior

Other information

Host OS

Output of sudo docker info

Docker run command or docker-compose file that you used

Other valuable info

(I'm rewriting mastercontainer in rust (to learn rust) and I found this...)

[docjyJ]

Maybe this behavior is intended for yaml, but it's confusing.

[szaimen]

Yes, it is intended because we generate https://github.com/nextcloud/all-in-one/blob/main/manual-install/latest.yml and https://github.com/nextcloud/all-in-one/tree/main/nextcloud-aio-helm-chart out of it. Do you have a better idea how to do that?

[docjyJ]

Why have a cap_drop in YAML, but not with the mastercontainer ?

[szaimen]

Because cap_drop is by default applied for all containers:

all-in-one/php/src/Docker/DockerActionManager.php

Line 519 in 267aebf

$requestBody['HostConfig']['CapDrop'] = ['NET_RAW'];

[szaimen]

Or WDYM?

[szaimen]

Linking to #3377 which was introduced first. Later #4116 was created.

[szaimen]

cap_drop, profiles, user, networks or expose

Actually, all of them are only there for the docker-compose yaml and the helm chart because they are generated out of the containers.json. In the mastercontainer itself is a separate logic to handle these, thus they are not actually needed for the mastercontainer.

How should we proceed with this issue?

[docjyJ]

Move this to discussions as ideas?

[szaimen]

Move this to discussions as ideas?

Sounds good 👍