Set propagation=rshared for NEXTCLOUD_MOUNT

[chatziko]

Hello,

I was wondering, is there a way to set propagation=rshared (instead of rprivate) to the bind mount created by NEXTCLOUD_MOUNT? This would allow to recursively access nested bind mounts.

A good use-case is to be able to mount zfs snapshots to use with Snapshots app. Each snapshot is essentially a separate bind mount so rshared is needed to properly access them inside the container.

The manual-install would be an option, but I was hoping to still be able to use AIO.

Thanks in advance.

[szaimen]

Hi, we currently don't set this manually and just use dockers default:

all-in-one/php/src/Docker/DockerActionManager.php

Line 217 in 74b3a0d

$volumeEntry = $volumeEntry . ':' . 'rw';

all-in-one/php/src/Docker/DockerActionManager.php

Line 230 in 74b3a0d

$requestBody['HostConfig']['Binds'] = $volumes;

In my test with an example vfatmount, mounts get indeed mounted recursively into the container as well. Maybe this is something that happens only with zfs snapshots?

[chatziko]

Thanks for the response, from what I can tell, nested directories that are already mounted when the container is launched are accessible, but directories mounted later are not, unless I set propagation=rshared (or rslave).

[szaimen]

from what I can tell, nested directories that are already mounted when the container is launched are accessible

I see. That is very unfortunate.

So what would be preferred then? rshared or rslave?

Also, I guess we would need to verify if this breaks on Docker Desktop:

From https://docs.docker.com/storage/bind-mounts/#configure-bind-propagation

[chatziko]

rslave should be enough for the snapshot use-case (haven't test it).

rshared is the most flexible, as it allows mounts inside the container to be visible outside. Not sure whether there is a good use-case for this in nextcloud, could be...

[szaimen]

So then we will go with rslave. Mounts from inside the containers do not need to be available from the outside and also should not be imho.

[chatziko]

Sounds great, I tested it and it works fine with zfs snapshots. Thanks a lot for fixing this!

[szaimen]

This will get addressed with #2601

[chatziko]

Looking forward to it, thanks again for the help!

[szaimen]

This is now released with v6.4.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

[chatziko]

I finally managed to test it in v7.0.0, it works great, many thanks!