Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Start Slideshow" tooltip gets focused on Modal opening #3381

Closed
nicokaiser opened this issue Oct 19, 2022 · 2 comments
Closed

"Start Slideshow" tooltip gets focused on Modal opening #3381

nicokaiser opened this issue Oct 19, 2022 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@nicokaiser
Copy link

Describe the bug
When clicking on a thumbnail in the Photos app, the photo is opened in the fullscreen (OCA viewer) view. However every time the viewer is opened, the "Start Slideshow" tooltip is displayed.

This might be because of it being focussed. It does not happen when opening photos from the Files app, thus I am reporting this issue here.

To Reproduce
Steps to reproduce the behavior:

  1. Open Photos app
  2. Click on any photo

Expected behavior
Full screen view should open, no tooltip should be visible

Screenshots
Bildschirmfoto 2022-10-19 um 18 45 05

Desktop

  • OS: macOS
  • Browser: Chrome

Server
Nextcloud 25.0.0
@nicokaiser nicokaiser added the bug Something isn't working label Oct 19, 2022
@skjnldsv
Copy link
Contributor

I also noticed this, it's because the first focusable item gets focused.
Moving to the vue components

@skjnldsv skjnldsv transferred this issue from nextcloud/photos Oct 19, 2022
@skjnldsv skjnldsv changed the title Unnecessary "Start Slideshow" tooltip "Start Slideshow" tooltip gets focused on Modal opening Oct 19, 2022
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Oct 19, 2022
@Antreesy
Copy link
Contributor

Resolved in current state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicokaiser @skjnldsv @Antreesy