From 8ae1a803ae6de5dd5066a3a7e24569b044460461 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Mon, 15 Jul 2024 22:30:17 +0200 Subject: [PATCH] fix(NcActions): Respect boundaries element for popover height Signed-off-by: Ferdinand Thiessen [skip ci] --- src/components/NcActions/NcActions.vue | 4 +++- styleguide.config.cjs | 1 + styleguide/assets/styleguide.css | 13 +++++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 styleguide/assets/styleguide.css diff --git a/src/components/NcActions/NcActions.vue b/src/components/NcActions/NcActions.vue index 19815b3a79..354d38cd7a 100644 --- a/src/components/NcActions/NcActions.vue +++ b/src/components/NcActions/NcActions.vue @@ -1072,7 +1072,7 @@ export default { */ boundariesElement: { type: Element, - default: () => document.querySelector('body'), + default: () => document.querySelector('#app-content-vue') ?? document.querySelector('body'), }, /** @@ -1361,6 +1361,8 @@ export default { actionHeight = action.clientHeight currentHeight += actionHeight } + } else { + inner.style.height = 'fit-content' } }, diff --git a/styleguide.config.cjs b/styleguide.config.cjs index c8741dcf99..59d910215e 100644 --- a/styleguide.config.cjs +++ b/styleguide.config.cjs @@ -30,6 +30,7 @@ module.exports = async () => { path.join(__dirname, 'styleguide/global.requires.js'), path.join(__dirname, 'styleguide/assets/icons.css'), path.join(__dirname, 'styleguide/assets/additional.css'), + path.join(__dirname, 'styleguide/assets/styleguide.css'), ], pagePerSection: true, minimize: true, diff --git a/styleguide/assets/styleguide.css b/styleguide/assets/styleguide.css new file mode 100644 index 0000000000..c1d94f5c34 --- /dev/null +++ b/styleguide/assets/styleguide.css @@ -0,0 +1,13 @@ +/*! + * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later + */ + +#rsg-root { + height: 100%; +} + +#rsg-root .rsg--root-1 { + height: 100%; + overflow: scroll; +}