-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change package to nextcloud test server #601
Comments
We could also rename this one and create tooling for both in the same repo? :) We're already supporting so many libs repos 🙈 |
💨 mono repo Completely unrelated, so please ignore this part^^ No but could also work, but then we should make dependencies optional, as you do not want to install fully Cypress just for docker or install Playwright when using Cypress 🙈 |
Both approaches (two repos or making cypress optional) are fine with me. |
Or we make it tooling agnostic, as the current methods do not really need Cypress or any other tooling. Of course I know that there is more here, but we basically do not have implemented selectors. |
So for me every solution would work, but I would like to rather have the setup stuff located in a shared package than maintaining a fork of that functions just within my apps 😅 |
See #601. This package is also used in playwright tests. Remove the peer dependency to avaoid automatic installation of cypress. I also considered making it an optional dependency. But then it would still be installed by default. Signed-off-by: Max <[email protected]>
See #601. This package is also used in playwright tests. Remove the peer dependency to avaoid automatic installation of cypress. I also considered making it an optional dependency. But then it would still be installed by default. Signed-off-by: Max <[email protected]>
See #601. This package is also used in playwright tests. Remove the peer dependency to avaoid automatic installation of cypress. I also considered making it an optional dependency. But then it would still be installed by default. Signed-off-by: Max <[email protected]>
This seems to be the current consensus - so I started by removing the cypress peer dependency: |
I changed the issue title to reflect the current discussion. |
Proposal
Turn this package into a generic
@nextcloud/test-server
possibly with integrations for multiple test frameworks.There are already apps using other E2E testing frameworks like Playwright.
The docker test server functionality in this repo is useful without Cypress - but this repo is currently tightly bound to cypress (naming, peer dependency, ...)
Steps
nextcloud-cypress
branch to keep track of the current state and possibly release bugfixes for@nextcloud/cypress
@nextcloud/test-server
Points to discuss
Naming
@nextcloud/test-server
is the most shortest most generic yet precise term I could come up with.@nextcloud/e2e-test-server
is more precise. I don't see a use for this outside of e2e testing.Can be discussed in the PR.
original issue by @susnux
I would like to split this package and create a new one like `@nextcloud/docker-testing-server` or similar.The reason is there are already apps using other E2E testing frameworks like PlayWright.
So currently either you copy paste the docker code from this package, you write it your own, or you install this package.
But installing this packages makes no sense as it will pull in Cypress even if you do not use Cypress.
So to separate into logically connected pieces I would separate into:
@nextcloud/cypress
-> This packages with Cypress integration for Nextcloud@nextcloud/testing-server
(or any other name you like) -> Creating and spinning up a testing serverWhat is your opinion on this? cc @skjnldsv @max-nextcloud @artonge @ShGKme
The text was updated successfully, but these errors were encountered: