Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): add nuxt framework client #10684

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

peterbud
Copy link

@peterbud peterbud commented Apr 22, 2024

☕️ Reasoning

This PR is aiming to add support for Nuxt framework to @AuthJS

🧢 Checklist

  • Add SetEnvDefaults to be consistent with other frameworks
  • Discuss CSRF vs Origin checking approach
  • Documentation
  • Ready to be merged

🎫 Affected issues

N/A

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:14pm

@ndom91
Copy link
Member

ndom91 commented Apr 22, 2024

Followup Todos for us:

  • Add example repo (nextauthjs/nuxt-example-app)
  • Ensure Balazs github token can write to that (for sync)
  • Double check example code sync to that new repo
  • Add nuxt example app Vercel project (with shared env vars)
  • Add nuxt.authjs.dev subdomain

package.json Outdated Show resolved Hide resolved
@orenmizr
Copy link

orenmizr commented May 7, 2024

is it possible to build it and use it as alpha until the production version released ? @peterbud

@peterbud
Copy link
Author

is it possible to build it and use it as alpha until the production version released ? @peterbud

I think we are pretty early in the process of creating this framework, I'd love to have a proper review from the AuthJS core members before suggesting to use this.

Copy link

vercel bot commented May 24, 2024

@peterbud is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented Jun 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ndom91
Copy link
Member

ndom91 commented Nov 3, 2024

Follow up for us once this is merged:

  • Add nuxt.authjs.dev subdomain in Vercel dashboard (redirect already in this PR)
  • Add example app
    • Create repository nextauthjs/nuxt-auth-example
    • Add new repo to .github/sync.yml
    • Create new Vercel project syncing from new nextauthjs/nuxt-auth-example repo
    • Link pre-existing account env vars (esp shared AUTH_SECRET for proxying)
    • Ensure the apps/examples/nuxt dir is syncing to nextauthjs/nuxt-auth-example correctly (Balazs often has to add the new repo to his PAT for the sync to work, otherwise permissions errors)
    • Add example app link to docs homepage (?)
  • Tweet about it 🥳 (?)

Anything I've missed?

@moshetanzer
Copy link

moshetanzer commented Nov 3, 2024

@ndom91
Removing NUXT_ from beginning of env vars will not let them be replaced in nuxt config in runtime properly.

@peterbud
Copy link
Author

peterbud commented Nov 3, 2024

@ndom91 Removing NUXT_ from beginning of env vars will not let them be replaced in nuxt config in runtime properly.

Yes, without the NUXT_ prefix they won't be read from the .env file and at runtime they won't be even considered.

@ndom91
Copy link
Member

ndom91 commented Nov 3, 2024

Okay gotcha, I'll revert that then. Unfortunately the auto-detect env vars from @auth/core wont work then without additional changes there, but that's okay for now imo

Copy link

socket-security bot commented Nov 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, shell +28 3.7 MB aws-sdk-bot
npm/@aws-sdk/[email protected] None +1 264 kB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@builder.io/[email protected] eval, network +1 2.59 MB shairez
npm/@builder.io/[email protected] eval 0 47.6 MB shairez
npm/@cloudflare/[email protected] None 0 4.29 MB wrangler-publisher
npm/@eslint/[email protected] None 0 47.7 kB eslintbot
npm/@eslint/[email protected] None 0 14.2 kB eslintbot, openjsfoundation
npm/@graphql-codegen/[email protected] environment, filesystem, network, shell, unsafe +59 15.2 MB dotansimha
npm/@graphql-codegen/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +43 15.7 MB dotansimha
npm/@graphql-typed-document-node/[email protected] None 0 2.96 kB dotansimha
npm/@inkeep/[email protected] Transitive: environment, filesystem, network, shell, unsafe +28 22.2 MB sarah-inkeep
npm/@mikro-orm/[email protected] environment, eval, filesystem, unsafe 0 889 kB b4nan
npm/@mikro-orm/[email protected] filesystem +1 354 kB b4nan
npm/@miniflare/[email protected] filesystem, unsafe Transitive: environment, eval, network, shell +5 460 kB wrangler-publisher
npm/@next/[email protected] None 0 14.2 kB matt.straka, rauchg, timer, ...2 more
npm/@nuxt/[email protected] None 0 147 kB danielroe
npm/@nuxt/[email protected] None 0 20.3 kB danielroe
npm/@nuxt/[email protected] None 0 580 kB danielroe
npm/@playwright/[email protected] None 0 25.3 kB dgozman-ms
npm/@preact/[email protected] Transitive: environment, filesystem, unsafe +37 12 MB marvinhagemeister
npm/@prettier/[email protected] environment 0 355 kB shinigami92
npm/@prisma/[email protected] environment, filesystem, shell 0 9.16 MB prismabot
npm/@prisma/[email protected] None 0 62.8 kB prismabot
npm/@radix-ui/[email protected] None +13 321 kB chancestrickland
npm/@radix-ui/[email protected] None +13 303 kB chancestrickland
npm/[email protected] None 0 3.26 MB antfu, patak, soda, ...2 more

🚮 Removed packages: npm/@auth/[email protected], npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@cloudflare/[email protected], npm/@solidjs/[email protected], npm/@solidjs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (a1cf406) to head (227440a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10684       +/-   ##
===========================================
+ Coverage   39.15%   77.17%   +38.02%     
===========================================
  Files         191      114       -77     
  Lines       29988     2936    -27052     
  Branches     1291      385      -906     
===========================================
- Hits        11742     2266     -9476     
+ Misses      18246      670    -17576     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orenmizr
Copy link

orenmizr commented Nov 6, 2024

i noticed next-auth changed in v5. will this be v5 compatible ? will this be offical nuxt or community ?

kudos @peterbud for sticking with it all this time.

@peterbud
Copy link
Author

i noticed next-auth changed in v5. will this be v5 compatible ?

v5 compatible

@peterbud
Copy link
Author

peterbud commented Nov 17, 2024

I'm not sure what else would be needed to move forward with this PR.

It has been open for more than 6 months, and recently I looked optimistic in the future as we finally managed to get the reviews completed with the help of the core team.

In the last 2 weeks this PR seems to be stalled again, and it's again drifting from the main branch.

Could you please answer the question honestly and make a decision on whether there is more effort to be done into this PR (and what that would be), or make the decision to cancel this PR. At this point I think canceling this PR is probably more respectful to each others time and energy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants