-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework): add nuxt framework client #10684
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
e4dbff6
to
b78106f
Compare
Followup Todos for us:
|
is it possible to build it and use it as alpha until the production version released ? @peterbud |
I think we are pretty early in the process of creating this framework, I'd love to have a proper review from the AuthJS core members before suggesting to use this. |
@peterbud is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Follow up for us once this is merged:
Anything I've missed? |
@ndom91 |
Yes, without the |
Okay gotcha, I'll revert that then. Unfortunately the auto-detect env vars from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10684 +/- ##
===========================================
+ Coverage 39.15% 77.17% +38.02%
===========================================
Files 191 114 -77
Lines 29988 2936 -27052
Branches 1291 385 -906
===========================================
- Hits 11742 2266 -9476
+ Misses 18246 670 -17576 ☔ View full report in Codecov by Sentry. |
i noticed next-auth changed in v5. will this be v5 compatible ? will this be offical nuxt or community ? kudos @peterbud for sticking with it all this time. |
v5 compatible |
I'm not sure what else would be needed to move forward with this PR. It has been open for more than 6 months, and recently I looked optimistic in the future as we finally managed to get the reviews completed with the help of the core team. In the last 2 weeks this PR seems to be stalled again, and it's again drifting from the main branch. Could you please answer the question honestly and make a decision on whether there is more effort to be done into this PR (and what that would be), or make the decision to cancel this PR. At this point I think canceling this PR is probably more respectful to each others time and energy. |
☕️ Reasoning
This PR is aiming to add support for Nuxt framework to
@AuthJS
🧢 Checklist
SetEnvDefaults
to be consistent with other frameworks🎫 Affected issues
N/A