fix(agent): Fixes 8T distributed traces #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using 8T the 'parentId' intrinics attribute was not being set for the root span of a service based on the inbound header. This caused fragmented traces. This commit added the required 'parentId' attribute. Normal DT (not 8T) was working correctly because the 'parentId' was being added to a span returned from nr_segement_to_span_event() in a different code path dedicated to JSON creation starting with nr_segment_tree_finalise(). A test in test_segment.c was modified to check that the 'parentId' is correctly set based on the inbound DT header.
Codecov Report
@@ Coverage Diff @@
## dev #724 +/- ##
==========================================
- Coverage 78.68% 78.15% -0.53%
==========================================
Files 188 188
Lines 26204 25887 -317
==========================================
- Hits 20618 20232 -386
- Misses 5586 5655 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mfulb
requested review from
ZNeumann,
zsistla,
lavarou,
bduranleau-nr and
hahuja2
bduranleau-nr
approved these changes
Sep 5, 2023
lavarou
approved these changes
Sep 6, 2023
zsistla
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 8T the 'parentId' intrinsics attribute was not being set for
the root span of a service to a value based on the inbound header. This caused
fragmented traces. This commit added the required 'parentId' attribute.
Normal DT (not 8T) was working correctly because the 'parentId' was
being added to a span returned from nr_segement_to_span_event()
in a different code path dedicated to JSON creation starting with
nr_segment_tree_finalise().
A test in test_segment.c was modified to check that the 'parentId'
is correctly set based on the inbound DT header.