Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC 332 -- Fieldset issue on tenant and homeowner pages #31

Open
damiansian opened this issue Jan 5, 2025 · 2 comments
Open

SC 332 -- Fieldset issue on tenant and homeowner pages #31

damiansian opened this issue Jan 5, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@damiansian
Copy link

damiansian commented Jan 5, 2025

URL

https://demo.fileyourstatetaxes.org/en/questions/nj-eligibility-health-insurance

Issue

Each checkbox option has its own fieldset so the grouping semantics is read aloud as each option were its own group instead of all the options belonging to a larger group.

Screen shot

Image

Screen shot shows each input has its own fieldset

WCAG Success Criterion

SC 3.3.2: Labels or Instructions (Level A)

Impacted users

Screen reader users rely on labels and instructions to understand how to fill out form elements properly.

Suggested fix

You can reference these solutions on CodePen:
https://codepen.io/dsian108/pen/YPKEoje?editors=1000

@damiansian damiansian added the bug Something isn't working label Jan 5, 2025
@damiansian damiansian changed the title SC XXX -- To come SC 332 -- Fieldset issue on health insurance eligibility page Jan 5, 2025
@mmazanec22 mmazanec22 moved this from To triage to In progress in NJ Innovate -- NJ Direct File Accessibility Jan 8, 2025
@mmazanec22 mmazanec22 changed the title SC 332 -- Fieldset issue on health insurance eligibility page SC 332 -- Fieldset issue on tenant and homeowner pages Jan 8, 2025
@mmazanec22
Copy link

@damiansian on these pages we've got some checkboxes that show and hide other checkboxes. How should we handle that? I had aria-controls on there to associated the showing checkbox with the shown but axe flagged it as a misapplied role.

@damiansian
Copy link
Author

damiansian commented Jan 8, 2025

@mmazanec22

This page was a bit odd to me for several reasons:

  1. The first response is not a question, it's a statement.
  2. Two responses (two and three) that are in fact questions do not create any conditional outcome like the fourth response.
  3. Now the fourth response's question does spawn a conditional response that is a statement like response number one.

One question I have is this... How important is it to make the last statement response conditional when the first response is also a statement and not a question? What is the level of importance in making this conditionally visible?

Also, might it be preferable to expose the relationship of Single-unit properties versus Multi-unit properties?

I have a proposal here in CodePen
https://codepen.io/dsian108/pen/ogvEWeR?editors=1000

three form fields wrapped in a legend that reads single-unit home and two checkbox responses wrapped in a legend that reads multi-unit properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants