Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC 331/332 -- Checkbox fieldset legend implementation on contact info page #21

Open
damiansian opened this issue Jan 4, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@damiansian
Copy link

damiansian commented Jan 4, 2025

URL

https://demo.fileyourstatetaxes.org/en/questions/notification-preferences

Issue

To come.

Screenshot

Image

Video walkthrough

fieldset_legend_checkboxes.mov

WCAG Success Criterion

SC 3.3.1: Error Identification (Level A)
SC 3.3.2: Labels or Instructions (Level A)

Impacted users

Screen reader users rely on labels and instructions to understand how to fill out form elements properly.

Suggested fix

This suggestion fixes the issues on Mac and PC screen readers and brings the form element up to full WCAG conformance. There are other issues solved for here that have separate bugs filed.

Here is the CodePen:
https://codepen.io/dsian108/pen/NPKwOMy?authentication_hash=PNkvYxxPJjpA

What changed:

  • Added autocomplete (SC 1.3.5)
  • Associated helper text (SC 3.3.2)
  • Used aria-describedby for helper text AND error text (SC 331 and 332)
 <p>Please select the option(s) that work best for you. </p>
<fieldset aria-describedby="helper">
<legend>I want to receive</legend>
	<div>
		<input type="checkbox" name="Text message" id="check_1">
    <label for="check_1">Text message</label>
	</div>
	<div>
		<input type="checkbox" name="Email" id="check_2">
    <label for="check_2">Email</label>
	</div>
</fieldset>
      
              <div>
    <p>
<span id="helper">At least one preference is required to proceed. </span>
  </div>
@damiansian damiansian added the bug Something isn't working label Jan 4, 2025
@mmazanec22 mmazanec22 moved this from To triage to In progress in NJ Innovate -- NJ Direct File Accessibility Jan 8, 2025
@mmazanec22 mmazanec22 changed the title SC 331/332 -- Checkbox fieldset legend implementation SC 331/332 -- Checkbox fieldset legend implementation on contact info page Jan 8, 2025
@mmazanec22 mmazanec22 moved this from In progress to To triage in NJ Innovate -- NJ Direct File Accessibility Jan 8, 2025
@mmazanec22 mmazanec22 moved this from To triage to Ticket created in NJ Innovate -- NJ Direct File Accessibility Jan 10, 2025
@mmazanec22 mmazanec22 moved this from Ticket created to In progress in NJ Innovate -- NJ Direct File Accessibility Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant