Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6-8hrs] Create a "Figure" streamfield block #1539

Open
1 of 5 tasks
nmorduch opened this issue Aug 19, 2020 · 3 comments
Open
1 of 5 tasks

[6-8hrs] Create a "Figure" streamfield block #1539

nmorduch opened this issue Aug 19, 2020 · 3 comments
Assignees
Labels
tool/python python, django, wagtail tool/templates html, css

Comments

@nmorduch
Copy link
Member

nmorduch commented Aug 19, 2020

  • [1hr] Create block
  • [1hr] Should also have sensible size options for images
  • [2-3hr] Should be able to include multiple images/graphics side by side
    • [1hr] Extra credit: Dropdown to switch between multiple graphics, always on mobile, optional on bigger screens
  • [2hr] Clean up (hide?) other image/graphic blocks
@nmorduch nmorduch self-assigned this Aug 19, 2020
@nmorduch nmorduch changed the title Create a "Figure" streamfield block [6hrs] Create a "Figure" streamfield block Aug 19, 2020
@nmorduch nmorduch changed the title [6hrs] Create a "Figure" streamfield block [6-8hrs] Create a "Figure" streamfield block Aug 19, 2020
@nmorduch
Copy link
Member Author

@chigby to make a new the model, FigureBlock should have:

  • title (plain text)
  • text (rich text. help text: "Displays below the title") (can we limit the length?)
  • caption (rich text. help text: "Displays like a footer") (can we limit the length?)
  • width (same options as on DatawrapperBlock)
  • streamfield: Can have 0-8 (inclusive) of: CustomImageBlock, DatawrapperBlock, IframeBlock, DatavizBlock
  • columns (number: 1-4 inclusive)

And it should be in the group 'Embeds'

@chigby
Copy link
Collaborator

chigby commented Sep 24, 2020

I've made a FigureBlock with these fields.. I'm not what models to enable it for? Or is that something you were planning on doing?

@chigby
Copy link
Collaborator

chigby commented Sep 25, 2020

@nmorduch Check out the draft PR here for the block code and a suuper basic template (and let me know if there are issues or enhancements you need to flesh out the html/css situation)

#1559

@nmorduch nmorduch linked a pull request Sep 29, 2020 that will close this issue
@nmorduch nmorduch added tool/python python, django, wagtail tool/templates html, css labels Jan 19, 2021
@nmorduch nmorduch removed the 1 high label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool/python python, django, wagtail tool/templates html, css
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants