Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #62

Open
4 tasks done
NathanMolinier opened this issue Sep 16, 2024 · 9 comments · May be fixed by #105
Open
4 tasks done

Improve README #62

NathanMolinier opened this issue Sep 16, 2024 · 9 comments · May be fixed by #105
Assignees
Labels
priority high To manage as soon as possible. Anything within the big picture, not nit-picky.

Comments

@NathanMolinier
Copy link

NathanMolinier commented Sep 16, 2024

Description

It looks like some information are missing in the README and it is not that intuitive to use the module:

  • How to open the extension ? (Don't understand step 7.) -- people need to know that they need to click on the dropdown menu for version 5.7.0:
Screenshot 2024-09-16 at 11 35 43 AM
  • Should we create a python environment ? Which python version ?

  • How to download Slicer 5.2.2. -- 3D Slicer version 5.2.2 link #61

  • The videos are a bit old and the UI has changed since

@sandrinebedard
Copy link
Member

How to find the config file:
image

@NathanMolinier
Copy link
Author

I'm not able to find the "examples" section in the drop down menu after adding the path and allowing developper mode:

slicer version 5.2.2

Screenshot 2024-09-16 at 11 39 57

@valosekj
Copy link
Member

It's not clear to me what "Window Level" and "Window Width" stand for

image

@tomDag25
Copy link

tomDag25 commented Sep 16, 2024

It seems you can automate the window level and window width in the Module section using Automatic W/L. It would be great to make it a default parameter and if you want to change the W/L you can but not force the user to put some arbitrary values.
Screenshot 2024-09-16 at 12 09 40

@AcastaPaloma
Copy link
Collaborator

AcastaPaloma commented Sep 17, 2024

@NathanMolinier did you add the src folder specifically - into the modules section? I think you have to put the direct parent folder of the python file for the extension.

@sandrinebedard You should be able to create a new segmentation and create an output folder from there. Only then you should be able to pick up from an existing output folder for segmentation/classification settings, labels, etc.

@NathanMolinier
Copy link
Author

NathanMolinier commented Sep 17, 2024

Yes I did it, see my screenshot:
Screenshot 2024-09-17 at 09 15 16

I found this but I don't know how to load the module
Screenshot 2024-09-17 at 09 28 27

Update: I managed to solve the problem by recloning the repository and installing missing python packages. It's not really clear why I had this issue in the first place.

@AcastaPaloma AcastaPaloma added the priority high To manage as soon as possible. Anything within the big picture, not nit-picky. label Oct 20, 2024
@maxradx
Copy link
Member

maxradx commented Oct 23, 2024

  • #Add tree in folder organization to specify how it shouldbe organized.

@maxradx maxradx self-assigned this Oct 31, 2024
@maxradx
Copy link
Member

maxradx commented Oct 31, 2024

Work in progress related to updating documentation. Will notify when up-to-date!

@maxradx maxradx linked a pull request Nov 18, 2024 that will close this issue
@maxradx maxradx linked a pull request Nov 18, 2024 that will close this issue
@maxradx
Copy link
Member

maxradx commented Nov 18, 2024

issue 62

@NathanMolinier
Should we create a python environment ? Which python version ? --- Slicer install its own version of Python, which is not the traditionnal version (mixed up with C++). If Slicer is able to be opened, then no need for other version of Python.
The videos are a bit old and the UI has changed since --- Only one up-to-date video (As of 2024-11-18) has been kept in the documentation PR.
I'm not able to find the "examples" section in the drop down menu after adding the path and allowing developper mode: --- that means SlicerCART has not been installed correctly. Try using the updated Installation steps (e.g. dragging the SlicerCART.py file in the module window although only the path appears)

@sandrinebedard
How to find the config file: --- you are right. This has to be implemented (not working with the actual version) only use-case scenario for now is

@valosekj
It's not clear to me what "Window Level" and "Window Width" stand for --- those are scans-related values. Should be disabled in MRI is not selected as the modality. There are issues related to it, that will be fixed in further PR.

@tomDag25
It seems you can automate the window level and window width in the Module section using Automatic W/L. It would be great to make it a default parameter and if you want to change the W/L you can but not force the user to put some arbitrary values. --- sure. Please refer to #67

All of this are addressed in the Pull Request 105 (#105) related to Documentation.

In brief, those aspects are addressed in PR 105. Please refer to it for any discussion.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority high To manage as soon as possible. Anything within the big picture, not nit-picky.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants