Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neurolibre Book button and Github Code buttons have same URLs #26

Open
Shotgunosine opened this issue Dec 16, 2020 · 2 comments
Open

Neurolibre Book button and Github Code buttons have same URLs #26

Shotgunosine opened this issue Dec 16, 2020 · 2 comments

Comments

@Shotgunosine
Copy link

Looks great overall, I just noticed a small issue when I was trying to find the code for the books. The Neurolibre Book button and the Github Code buttons both point to the Neurolibre Book URL. I was able to find the code linked from the book page itself, but it's a little unexpected that the code button doesn't go to the github repo.

@pbellec
Copy link
Member

pbellec commented Dec 16, 2020

indeed, thanks for pointing it out!

agahkarakuzu added a commit that referenced this issue Dec 16, 2020
@agahkarakuzu
Copy link
Member

Thank you @Shotgunosine! 0205927 should fix it now.

@pbellec some of the books are resourced from outside, for them I added temporary ext in the yamls.

pbellec added a commit that referenced this issue Sep 23, 2021
This reverts commit 0205927.
pbellec added a commit that referenced this issue Sep 23, 2021
This reverts commit f8154b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants