Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter books on the website are not from neurolibre organization #25

Open
ltetrel opened this issue Jun 15, 2020 · 7 comments
Open

Jupyter books on the website are not from neurolibre organization #25

ltetrel opened this issue Jun 15, 2020 · 7 comments

Comments

@ltetrel
Copy link
Contributor

ltetrel commented Jun 15, 2020

the submissions on https://www.neurolibre.com/ points to various location:

They should all point to https://neurolibre.github.io instead to disable bypassing our submission workflow.

@ltetrel
Copy link
Contributor Author

ltetrel commented Jun 15, 2020

I temporarily disabled the banned_specs config to allow for these notebooks to build correctly on our binderhub.

@emdupre
Copy link
Member

emdupre commented Jun 15, 2020

At least one has been forked already, no? https://github.com/neurolibre/vcog_hps_ad_book

The others could either be forked or we could "submit" them to test out the submission workflow.

@agahkarakuzu
Copy link
Member

@emdupre the submit workflow is available at https://github.com/roboneurotest right now, I can add them to NeuroLibre organization for testing.

@emdupre
Copy link
Member

emdupre commented Jun 15, 2020

If we can use this as a test of the submission workflow, I think that'd be great !

One complication is that at least introML-book and vcog_hps_ad_book are already converted into Jupyter Books, so the build step of our workflow wouldn't work.

@ltetrel is right that we also have the introML repository, which would be a more accurate test. I'm not sure if there's something equivalent for vcog_hps_ad. Do you know, @ltetrel ?

@ltetrel
Copy link
Contributor Author

ltetrel commented Jun 15, 2020

Yes I already converted it to jupyter book, but I could also take the raw repo https://github.com/SIMEXP/vcog_hps_ad and we could test on that.

@emdupre
Copy link
Member

emdupre commented Jun 15, 2020

@agahkarakuzu can correct me if I'm wrong, but I think we should in fact be working with the original repositories for roboneuro 🤖 to work off of !

@agahkarakuzu
Copy link
Member

@emdupre yes, the only reason I kept script in a different repo was not to bother people with thousands of notifications :)

I can move them here sometime tomorrow, would that be ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants