Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit if .env needs to be mounted into the container #87

Closed
alyssadai opened this issue Oct 10, 2024 · 1 comment · Fixed by #90
Closed

Revisit if .env needs to be mounted into the container #87

alyssadai opened this issue Oct 10, 2024 · 1 comment · Fixed by #90
Assignees
@rmanaem
Labels
refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Oct 10, 2024 •
edited
Loading

All variables used by graphdb_setup.sh should already be set in the environment instruction of the service itself. So, it should not be necessary to re-export these variables using the .env file.

Also, confirm whether NB_GRAPH_ADDRESS needs to be specified as an env variable in the graph service - this variable doesn't seem to be referenced anywhere in the setup scripts.

To clarify, we still need to keep the .env itself for docker-compose.yml, but most likely ALSO mounting it into the graph container isn't necessary.
@alyssadai alyssadai added flag:schedule Flag issue that should go on the roadmap or backlog. and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Oct 23, 2024
@alyssadai alyssadai moved this to Backlog in Neurobagel Oct 23, 2024
@rmanaem rmanaem self-assigned this Oct 23, 2024
@rmanaem rmanaem added refactor Simplifying or restructuring existing code or documentation. type:maintenance labels Oct 23, 2024
@rmanaem rmanaem moved this from Backlog to Implement - Active in Neurobagel Oct 23, 2024
@rmanaem rmanaem mentioned this issue Oct 23, 2024
Merged
7 tasks
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Implement - Done to Review - Done in Neurobagel Oct 23, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

🚀 Issue was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MNT] Removed .env volume from graph service neurobagel/recipes
2 participants
@alyssadai @rmanaem