Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NB_API_QUERY_URL to NB_API_URL or similar #82

Open
alyssadai opened this issue Aug 16, 2024 · 1 comment
Open

Rename NB_API_QUERY_URL to NB_API_URL or similar #82

alyssadai opened this issue Aug 16, 2024 · 1 comment
Labels
refactor Simplifying or restructuring existing code or documentation.

Comments

@alyssadai
Copy link
Contributor

NB_API_QUERY_URL can be slightly confusing because it:

  1. Does not refer to the query tool URL
  2. Does not refer only to the /query endpoint for the API, rather it is the base URL for the API which endpoints are appended to

To improve clarity and prevent confusion with NB_QUERY_APP_BASE_PATH, maybe we can consider renaming this to simply NB_API_URL or NB_FAPI_URL.

@alyssadai alyssadai added refactor Simplifying or restructuring existing code or documentation. type:maintenance labels Aug 16, 2024
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Oct 31, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

No branches or pull requests

2 participants