Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] replace bind-mount for graphDB home with docker volume #55

Closed
1 task done
surchs opened this issue May 12, 2024 · 1 comment · Fixed by #57
Closed
1 task done

[ENH] replace bind-mount for graphDB home with docker volume #55

surchs opened this issue May 12, 2024 · 1 comment · Fixed by #57
Assignees
Labels
released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented May 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

New feature

Right now, we store the graphDB home for each docker compose stack on the host FS directly via bind-mounts:

volumes:
- "${NB_GRAPH_ROOT_HOST:-~/graphdb-home}:${NB_GRAPH_ROOT_CONT:-/opt/graphdb/home}"

This causes at least these issues

  • user has to define a path for the graphDB home on the host
  • if the user leaves the default path and starts multiple compose stacks, they may end up sharing the same graphDB home, leading to conflicts
  • removing or cleaning up the graphDB home is something the user has to do outside of docker/docker-compose via regular FS operations (i.e. rm -rf ...)

There will never be a use case for us to write to the graphDB home from the host computer because only the container will write to it and read from it. I.e.: as long as the container has access to the graphDB home, we don't care if the host can see this directory as well. That's exactly what docker volumes are meant to handle: https://docs.docker.com/storage/volumes/

So we should switch from bind-mounts to volumes for graphDB

Unclear documentation

No response

@surchs surchs self-assigned this May 14, 2024
@surchs surchs moved this to Implement - Active in Neurobagel May 14, 2024
surchs added a commit that referenced this issue May 14, 2024
@surchs surchs moved this from Implement - Active to Implement - Done in Neurobagel May 14, 2024
@alyssadai alyssadai moved this from Implement - Done to Review - Active in Neurobagel May 14, 2024
@alyssadai alyssadai moved this from Review - Active to Implement - Done in Neurobagel May 14, 2024
@alyssadai alyssadai moved this from Implement - Done to Community in Neurobagel May 14, 2024
@alyssadai alyssadai moved this from Community to Implement - Done in Neurobagel May 14, 2024
@alyssadai alyssadai moved this from Implement - Done to Review - Active in Neurobagel May 15, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel May 16, 2024
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 Issue was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant