Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to pydantic v2 #180

Open
2 tasks
alyssadai opened this issue Jul 21, 2023 · 4 comments
Open
2 tasks

Migration to pydantic v2 #180

alyssadai opened this issue Jul 21, 2023 · 4 comments
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again importance:medium We will address this but will delay for higher priority items. maint:dependency Dependency updates and their version upgrades. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Jul 21, 2023

The release of Pydantic V2 introduced several breaking changes in the code due to name changes of multiple methods, removed or deprecated types/methods/objects, and broader changes to the logic of fields, validators, + more.

The docs for V2 have not quite caught up to the changes yet, but there is a comprehensive migration guide 🎉
https://docs.pydantic.dev/dev-v2/migration/ and pretty detailed PydanticUserErrors

Related are:
#179

TODO:

  • investigate needed refactor for moving to pydantic 2
  • refactor to enable pydantic 2 and migrate
@alyssadai alyssadai added importance:urgent We will address this as soon as possible. severity:critical A broken feature with a workaround that is unacceptably complex flag:discuss Flag issue that needs to be discussed before it can be implemented. labels Jul 21, 2023
@alyssadai alyssadai added severity:blocker A bug or broken feature with no workaround severity:critical A broken feature with a workaround that is unacceptably complex and removed severity:critical A broken feature with a workaround that is unacceptably complex severity:blocker A bug or broken feature with no workaround labels Jul 21, 2023
@alyssadai
Copy link
Contributor Author

Any thoughts @surchs?

I've started making some of the necessary changes (based on currently failing tests) in a branch and think the migration shouldn't require any major rewrites on our end, but some of the updates related to deprecated methods would probably benefit from a closer look as they involve a bit of extra code to preserve existing behavior.

@surchs surchs added importance:medium We will address this but will delay for higher priority items. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:dependency Dependency updates and their version upgrades. flag:blocker flag that issue is blocking at least one other issue from being completed. severity:blocker A bug or broken feature with no workaround and removed importance:urgent We will address this as soon as possible. severity:critical A broken feature with a workaround that is unacceptably complex labels Aug 17, 2023
@surchs
Copy link
Contributor

surchs commented Aug 22, 2023

Bumping this up since my ill advised late night commit (1d4cb52) to main has made this an actual blocker.

@alyssadai
Copy link
Contributor Author

Will pin pydantic version for now. Taking this issue off of backlog in favour of #184.

@alyssadai alyssadai removed flag:blocker flag that issue is blocking at least one other issue from being completed. severity:blocker A bug or broken feature with no workaround labels Aug 22, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again importance:medium We will address this but will delay for higher priority items. maint:dependency Dependency updates and their version upgrades. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: No status
Development

No branches or pull requests

2 participants