Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

our pinned orjson has no python3.12 wheels and needs to be built locally with Rust #237

Closed
surchs opened this issue Dec 6, 2023 · 2 comments
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again

Comments

@surchs
Copy link
Contributor

surchs commented Dec 6, 2023

here's the end of my pip install run

Collecting orjson==3.8.6 (from -r requirements.txt (line 18))
  Using cached orjson-3.8.6.tar.gz (655 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      
      Cargo, the Rust package manager, is not installed or is not on PATH.
      This package requires Rust and Cargo to compile extensions. Install it through
      the system's package manager or via https://rustup.rs/
      
      Checking for Rust toolchain....
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

This is with python 3.12.0 on a new fedora 39 machine.

edit: so the problem here is that the pinend orjson version

orjson==3.8.6

does not have wheels for python3.12 on pypi - makes sense, 3.12 wasn't released then. But this means I need the local build dependencies.

We should test that our builds succeed on newer python versions so we can detect this automatically and bump the versions accordingly.

See e.g. here: neurobagel/planning#23

@surchs surchs added the type:bug label Dec 6, 2023
@surchs surchs added this to Neurobagel Dec 6, 2023
@surchs surchs changed the title local setup fails when Rust is not installed our pinned orjson has no python3.12 wheels and needs to be built locally with Rust Dec 6, 2023
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 20, 2024
@surchs
Copy link
Contributor Author

surchs commented Apr 24, 2024

No longer an issue: https://pypi.org/project/orjson/3.10.1/#files

@surchs surchs closed this as completed Apr 24, 2024
@github-project-automation github-project-automation bot moved this to Review - Done in Neurobagel Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again
Projects
Archived in project
Development

No branches or pull requests

1 participant