Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TriggerSender #5

Closed
steelec opened this issue Aug 27, 2022 · 7 comments
Closed

add TriggerSender #5

steelec opened this issue Aug 27, 2022 · 7 comments
Assignees

Comments

@steelec
Copy link
Member

steelec commented Aug 27, 2022

Create TriggerSender class in hardware and pull all the way through to the Trial level as per discussion w/ @theHilikus
skeleton outlined in df91dc31ad12553760eff484f6dfabb954cda9b9

@steelec steelec self-assigned this Aug 27, 2022
@steelec
Copy link
Member Author

steelec commented Sep 17, 2022

implemented in https://github.com/neuralabc/spft-java/tree/enh-trigger, awaiting final device testing for merge

@steelec
Copy link
Member Author

steelec commented Sep 17, 2022

@ajhelum to confirm:

  • inclusion of / enabling of trigger does not affect data recording
  • inclusion of / enabling of trigger does not affect temporal precision of program (including smoothness of display to monitor)
  • inclusion of / enabling of trigger does not affect CPU usage (which could result in any of the above)
  • arduino trigger device does not affect EMG
  • arduino trigger device does not affect EEG

@steelec
Copy link
Member Author

steelec commented Sep 17, 2022

implemented in https://github.com/neuralabc/spft-java/tree/enh-trigger, awaiting final device testing for merge

note other changes in this branch will include altering the meaning of presentation frequency to refer to # milliseconds for displaying each element of a sequence (from Hz, which was less precise) and likely some intermediate implementation of dynamic time warping ( #6 )

@ajhelum
Copy link

ajhelum commented May 3, 2023

Arduino trigger device is receiving trigger signals from SPFT for all testing files (yaml) smoothly, in one java session. (no need to open fresh session for running separate files)
Tested with 1.4 jar (recent as of May 03 2023).
No trigger delays observed.

@steelec
Copy link
Member Author

steelec commented May 3, 2023

thank you for the testing, I think this is ready for merge into main

@steelec steelec pinned this issue May 3, 2023
@steelec
Copy link
Member Author

steelec commented May 3, 2023

included here: #8

@steelec
Copy link
Member Author

steelec commented Aug 25, 2023

now #8 merged into main

@steelec steelec closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants