Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Issues found while implementing #4

Open
Powerhamster opened this issue Dec 31, 2018 · 2 comments
Open

Some Issues found while implementing #4

Powerhamster opened this issue Dec 31, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@Powerhamster
Copy link

  • Circle radius is ignored
  • Method equivalent to get LatLngBounds from LatLng[] is missing
  • Method calls on PopUps will be rendered twice e.g.
$popUp->on('add', (new AnonymousFunction())->addLine('console.log("add");');
  • Map::encodeMap only renders variables and non of the layers
  • Traits and Interfaces are not consistent
    • Traits will be used multiple time through inheritance

https://github.com/netzmacht/php-leaflet/compare/master...Powerhamster:powerhamster-fixes?expand=1

@dmolineus
Copy link
Member

Circle radius is ignored

Fixed with 1923f5d.

Method calls on PopUps will be rendered twice e.g.

Fixed with 6492f6b.

Map::encodeMap only renders variables and non of the layers

I added some functional tests before fixing the issues above. Could you please provide a test case for this issue as a PR? I haven't had a look on it but as this library is used on hundreds of websites - without having this issue - I'd be happy to see how to reproduce it.

@dmolineus dmolineus added this to the 1.1.1 milestone Jan 2, 2019
@Powerhamster
Copy link
Author

#5
This example should look like in description of the request but instead it's only grey. No tile layer or marker is rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants