-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uses of banner_is_disabled()
to not preclude -V
printouts
#2573
Labels
bug
Low-hanging fruit
A proposal or issue that is good for newcomers to codebase or otherwise a quick win
service/daemon start/stop
General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug
Milestone
Comments
jimklimov
added
bug
service/daemon start/stop
General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug
Low-hanging fruit
A proposal or issue that is good for newcomers to codebase or otherwise a quick win
labels
Aug 1, 2024
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…programs to print_banner_once() [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…ayout there [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
… "-V" handling [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…g program versions [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…programs to describe_NUT_VERSION_once() [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…ON_once() rather than directly UPS_VERSION [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…with its copy of describe_NUT_VERSION_once() instead of large code chunk in the program [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…pass it to print_banner_once() and show_usage() [networkupstools#2573] Also update tools/nut-scanner/Makefile.am to have the symbols in libnutscan Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
… follow common NUT pattern [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…etworkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…help and new standalone option) [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…T_VERSION_once() copy of the code [networkupstools#2573] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added a commit
to jimklimov/nut
that referenced
this issue
Aug 5, 2024
…ion.h" [networkupstools#2573, networkupstools#2097] Signed-off-by: Jim Klimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Low-hanging fruit
A proposal or issue that is good for newcomers to codebase or otherwise a quick win
service/daemon start/stop
General subject for starting and stopping NUT daemons (drivers, server, monitor); also BG/FG/Debug
Some NUT programs only print the version banner when asked to by
-V
argument, a few others did so always until it became configurable by an envvar toggle with PR #2568. Their implementations of-V
handling were essentially no-ops because the banner is always there.Now these few programs should be revised to check if the banner was forbidden by default, and re-print it in
-V
clause handling. It would then help to offload the banner-printing into a method, whether incommon
or privately per-tool sources.Also it would be helpful for
upsdrvctl status
andupsdrvsvcctl status
parsing to have a way (envvar or CLI option like-H
in Solaris common semantics) to not print the table heading, showing only the content lines. If doing-H
, it should also preclude the NUT banner printing (so maybe a quick arg parsing loop to check ifH
is present, like already done in some other code checking for debug early on).The text was updated successfully, but these errors were encountered: