Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to implement nut-scanner -m auto* modes on WIN32 #2516

Closed
jimklimov opened this issue Jul 8, 2024 · 0 comments · Fixed by #2521
Closed

Need to implement nut-scanner -m auto* modes on WIN32 #2516

jimklimov opened this issue Jul 8, 2024 · 0 comments · Fixed by #2521
Labels
nut-scanner Windows Windows-not-on-par-with-POSIX Aspect of Windows builds known to be dysfunctional compared to POSIX builds; fix needed to be on par
Milestone
2.8.3

Comments

@jimklimov
Copy link
Member

As of PR #2513 and #2509 with initial implementation for issue #2244, WIN32 code for discovery of local addresses is a stub that likely needs Windows-specific methods (first shot with POSIX ones failed). See #2513 (comment) for initial thoughts.
@jimklimov jimklimov added Windows nut-scanner Windows-not-on-par-with-POSIX Aspect of Windows builds known to be dysfunctional compared to POSIX builds; fix needed to be on par labels Jul 8, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Jul 8, 2024
@jimklimov jimklimov changed the title Teach nut-scanner -m auto* modes on WIN32 Need to implement nut-scanner -m auto* modes on WIN32 Jul 8, 2024
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
m4/nut_check_headers_windows.m4: introduce NUT_CHECK_HEADER_IPHLPAPI [n…
b5ee6aa 
…etworkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
configure.ac, tools/nut-scanner/Makefile.am: detect WIN32 support of …
4184fd6 
…newer GetAdaptersAddresses() and/or older GetAdaptersInfo() [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
tools/nut-scanner/*: move WIN32 WSAStartup() rituals to nutscan_init(…
052c8e8 
…) so they only run once and for all [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
tools/nut-scanner/nut-scanner.c: implement "-m auto" for two WIN32 AP…
7ebbede 
…Is [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov mentioned this issue Jul 9, 2024
Merged
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
configure.ac: fix location of NUT_CHECK_HEADER_IPHLPAPI call [network…
057ae96 
…upstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
NEWS.adoc: update nut-scanner -m auto note - WIN32 is now supported…
53943d1 
… too [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
configure.ac: fix location of NUT_CHECK_HEADER_IPHLPAPI call [network…
3710a76 
…upstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
tools/nut-scanner/*: move WIN32 WSAStartup() rituals to nutscan_init(…
eb84deb 
…) so they only run once and for all [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
NEWS.adoc: update nut-scanner -m auto note - WIN32 is now supported…
14bb3c9 
… too [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
tools/nut-scanner/nut-scanner.c: implement "-m auto" for two WIN32 AP…
a4734f0 
…Is [networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Jul 9, 2024
@jimklimov
tools/nut-scanner/nut-scanner.c: add a warning comment about bit-coun…
fd4106a 
…ting for `-m auto` [networkupstools#2244, networkupstools#2516]

Signed-off-by: Jim Klimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nut-scanner Windows Windows-not-on-par-with-POSIX Aspect of Windows builds known to be dysfunctional compared to POSIX builds; fix needed to be on par
Projects
NUT for Windows
Status: Done
Milestone
2.8.3
Development

Successfully merging a pull request may close this issue.

Implement nut-scanner -m auto* modes on WIN32 jimklimov/nut
1 participant
@jimklimov