Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from FTY branch: do_convert_deci support in drivers/netxml-ups.c? #2342

Closed
jimklimov opened this issue Mar 2, 2024 · 1 comment
Closed
Assignees
Milestone

Comments

@jimklimov
Copy link
Member

Follow-up from #2275

Currently the FTY branch includes code for decimal conversions with very old MGE devices. It is mentioned in netxml-ups and mge-xml codebases. I am not sure if it even is not a mis-merge of some earlier resyncs from master to FTY, as some of those commits purported to relocate or drop this... I think.

  • dfc1019 (Jim Klimov 2017-02-27 15:16:07 +0100)
  • e15aa22 (Jim Klimov 2017-02-27 16:22:10 +0100)
  • bc7c4e3 (Jim Klimov 2017-02-28 10:16:06 +0100)
  • 957c1cb (Jim Klimov 2024-01-25 10:38:52 +0100) - minor build fix
@jimklimov
Copy link
Member Author

Per analysis in #1316,

actually the FTY part should be dropped, left-over from when the do_convert_deci toggle was converted from boolean setting into a flag checked right in mge-xml.c; will be posted in #2472 resync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants