Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download sources" page should offer newest *release*, not just newest tag #34

Closed
jimklimov opened this issue Jun 1, 2023 · 4 comments
Labels

Comments

@jimklimov
Copy link
Member

jimklimov commented Jun 1, 2023

NUT repository has a number of tags for intermediate milestones during development, which are not releases (candidates, major side project merges).

However the website links from https://networkupstools.org/download.html#_stable_tree_2_8 seem to report just the newest (possibly annotated) git tag => inspired link. For example, at the moment it suggests http://www.networkupstools.org/source/2.8/nut-2.8.0-Windows.tar.gz which is not even published among sources (separate repo) which may in fact be a criterion for choosing what maintainers think is a release - just pick the newest of those.

@jimklimov jimklimov added the bug label Jun 1, 2023
@jimklimov jimklimov changed the title Download spurces should offer newest *release*, not just newest tag "Download sources" page should offer newest *release*, not just newest tag Jun 1, 2023
@jimklimov
Copy link
Member Author

jimklimov commented Jun 1, 2023

Looking at https://github.com/networkupstools/nut/blob/f236b5e60837680223af83ff8c69460f862eba52/docs/download.txt#L23-L33 the practical problem is determining the revision correctly - seeded to PACKAGE_VERSION in

nut-website/Makefile.am

Lines 89 to 90 in 6436163

--attribute=revision="$(PACKAGE_VERSION)" \
--attribute=webrevision="$(WEBSITE_VERSION)" \

This brings the issue closer to #35 and networkupstools/nut#1949 ...

@jimklimov
Copy link
Member Author

Seems --match 'v[0-9]*.[0-9]*.[0-9]-signed' --match 'v[0-9]*.[0-9]*.[0-9]' --exclude '*rc*' --exclude '*alpha*' --exclude '*beta*' args to git describe can do the trick...

@jimklimov
Copy link
Member Author

...or perhaps without the -signed tags, to avoid confusing "nut-2.8.0-signed.tar.gz" expectations.

@jimklimov
Copy link
Member Author

fixed with today's website builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant