Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBox v3.0 Support #142

Open
ryanmerolle opened this issue Jul 28, 2021 · 18 comments
Open

NetBox v3.0 Support #142

ryanmerolle opened this issue Jul 28, 2021 · 18 comments

Comments

@ryanmerolle
Copy link
Contributor

Environment

  • Python version: 3.7.7
  • NetBox version: 3.0-beta1
  • ntc-netbox-plugin-onboarding version: 2.1.0

Proposed Functionality

As an FYI here is what changed that could impact or help the plugin:

If you find any issues or have any questions feel free to hit us on the slack or add a bug /issue or add to the umbrella UI issue netbox-community/netbox/issues/6797

Use Case

Longterm NetBox compatibility.

@ryanmerolle ryanmerolle changed the title NetBox v3.0-beta1 Support NetBox v3.0 Support Sep 2, 2021
@cichutkiii
Copy link

I have the same question. Will it be updated to support netbox 3.0 ?

@rgforge
Copy link

rgforge commented Nov 22, 2021

I can not get it to work on Netbox 3.0. I get the following error when running python3 manage.py migrate. "django.core.exceptions.ImproperlyConfigured: Plugin netbox_onboarding requires NetBox maximum version 2.11.99." It also kills my web access with "503 Service Unavailable." Thank goodness for VM snapshots.

@jvanderaa
Copy link
Contributor

This won't be a "quick fix" by any means. With NetBox deprecating Python3.6, moving this to just change the version numbering aspect, there are complaints about not having the proper compliant Python version. To do this right I would anticipate now needing to maintain multiple development branches. There are places that are still on NetBox 2.x with Python3.6. So we would need to have a new major release to support the deprecation. New features may have to get developed into multiple branches and such.

@jvanderaa
Copy link
Contributor

@ryanmerolle did I hear somewhere that caching was removed as well?

@ryanmerolle
Copy link
Contributor Author

Yea in 3.0

@uck9
Copy link

uck9 commented Dec 23, 2021

Updating the code to permit the installation based on version number plus some edits in the templates does permit this plugin to work in 3.0 and 3.1. Been running a custom copy for a while now and basic functionality is working, just some inconsistencies with the templates still.

@CalderValleyIT
Copy link

Is an update for 3.0+ still in the works?

@devdog1
Copy link

devdog1 commented Aug 12, 2022

@uck9 coming back from an old post do you happen to have a version that will work in ver. 3? or has someone forked this for support with 3.*?

@gaby
Copy link

gaby commented Sep 9, 2022

Any updates on this, or should we fork this project?

We have hundreds of devices and this plugin would ease populating our newly created netbox instance.

@jvanderaa
Copy link
Contributor

@gaby waiting for some help on this one.

@jvanderaa
Copy link
Contributor

Note, I started to look at if it was a small change that NetBox did or a big change. It is a big change indeed that will need to be done.

@gaby
Copy link

gaby commented Sep 28, 2022

@jvanderaa The problem is that none of the maintainers seem to respond. Even though this project is mentioned in their other tools.

@dgarros @mzbroch @glennmatthews Can we get some feedbCl regarding Netbox v3 support?

@chadell
Copy link
Collaborator

chadell commented Sep 30, 2022

Hi @gaby , @cichutkiii , @ryanmerolle , @devdog1 , @CalderValleyIT

Our workload has been high with customers and other open source projects, which as brought less focus here.
In the meantime, we are more than happy to accept contributions though.

@gaby
Copy link

gaby commented Sep 30, 2022

@chadell Could we start by merging #152 #148 #151 #150 #147

@gaby
Copy link

gaby commented Sep 30, 2022

Also #140 #145

@chadell
Copy link
Collaborator

chadell commented Oct 12, 2022

Before being able to merge more PRs, addressing #158 is needed to make sure nothing is being broken.
As usual, contributions are welcome.

@uck9
Copy link

uck9 commented Mar 26, 2023

If anyone's interested, I've done a quick and dirty fixup of the current code to support (at least on my install) Netbox 3.4. 99% of the fixups were in the templates but I've done away with support for V2 of Netbox in my forked copy.

Note the Quick and dirty status of this one. I'm still getting my head round Python/Django/Netbox so I've not used any CI, Linting, tests on the fork at this stage. Just needed to get this one working so I can continue to support a production instance of Netbox with this plugin. A manual install of the package will be required if you're wanting to use my forked copy.

Hope this assists others in some way. When I get more across using the right tools, I might try and get these changes rolled back into the original ntc package.

https://github.com/uck9/ntc-netbox-plugin-onboarding

@modonovan
Copy link

Hey @uck9, many thanks for your efforts to fixup this plugin for 3.x support. It's really appreciated! I have to ask the dump question, and I'm asking here so that others have visibility too:

What are the specific installation instructions for your fork? I mean, the pip install method that's listed in the original README seems to be the same in your README which surely means that the python module installed will be the originally published module. I'd very much like to test your forked version on a 3.x install but am I little confused as to how best to do this in a docker installation. Would you be able to give me/us some pointers please?

Also, in a more broader sense, I'd wholeheartedly endorse those in the know updating the released version to support 3.x installations. Whilst I'm not up to speed enough to help myself, I'd be glad to help with whatever efforts are needed to try and get this plugin ported to properly support 3.x installs out of the box.

Regards,
-Mick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants