Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diffsync.DiffSync naming #233

Closed
Tracked by #232
Kircheneer opened this issue Jun 22, 2023 · 4 comments
Closed
Tracked by #232

diffsync.DiffSync naming #233

Kircheneer opened this issue Jun 22, 2023 · 4 comments
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping
Milestone
2.0.0

Comments

@Kircheneer
Copy link
Collaborator

Since we are calling subclasses of diffsync.DiffSyncadapters in the examples and even in the docs

When you initialize the Diffsync Adapter class

maybe we should just rename the class to diffsync.Adapter? To me this is clearer.
@Kircheneer Kircheneer added status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping labels Jun 22, 2023
@Kircheneer Kircheneer added this to the 2.0.0 milestone Jun 22, 2023
@glennmatthews
Copy link
Collaborator

I'd be in favor of this change. :-)

@chadell
Copy link
Collaborator

chadell commented Jun 26, 2023

It looks good to me too

@Kircheneer Kircheneer mentioned this issue Aug 24, 2023
Open
7 tasks
@Kircheneer
Copy link
Collaborator Author

We should keep the old name around for at least a couple of minor versions I think, but change the docs to point to the new one.

@Kircheneer Kircheneer mentioned this issue Aug 24, 2023
Merged
@Kircheneer
Copy link
Collaborator Author

Closed with #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: gathering feedback Further discussion is needed to determine this issue's scope and/or implementation type: housekeeping
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@glennmatthews @Kircheneer @chadell