Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymized IP addresses in tests #166

Closed
chadell opened this issue Sep 18, 2022 · 2 comments · May be fixed by #165
Closed

Anonymized IP addresses in tests #166

chadell opened this issue Sep 18, 2022 · 2 comments · May be fixed by #165
Assignees
@chadell

Comments

@chadell
Copy link
Collaborator

chadell commented Sep 18, 2022

Environment

  • Python version:
  • circuit_maintenance_parser version: 2.1.0

Expected Behavior

Test data should not contain any public IP addresses for anonymity purposes.

Observed Behavior

Some files contains public IPv4 and IPv6 addresses.

Steps to Reproduce
@chadell chadell self-assigned this Sep 18, 2022
@chadell chadell mentioned this issue Sep 18, 2022
Open
3 tasks
@glennmatthews glennmatthews linked a pull request Oct 21, 2022 that will close this issue
Add a CI check to validate IP address present in tests, and a helper to clean them #165
Open
3 tasks
@chadell
Copy link
Collaborator Author

chadell commented Oct 24, 2022

with #169 , this issue is mitigated with a script to anonymise IPs. However, it could be improved as suggested in #165 if the anonymation was predictable

@chadell
Copy link
Collaborator Author

chadell commented May 22, 2023

closing for now as #169 solved it

@chadell chadell closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadell chadell

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chadell