Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Does not compile with upstream libdragon by default #31

Open
gameblabla opened this issue Aug 22, 2019 · 4 comments
Open

Does not compile with upstream libdragon by default #31

gameblabla opened this issue Aug 22, 2019 · 4 comments

Comments

@gameblabla
Copy link

As the title suggests, currently it does not compile as is with upstream libdragon.
I have a few branches and workarounds to make it work with upstream, see here :
https://github.com/gameblabla/altra64/tree/upstream_libd_fix
https://github.com/gameblabla/altra64/tree/fixmakefile_upstream
gameblabla@29a6b71

However, i noticed in one of your pull requests that you intend on using an old fork of conker's libdragon. Do you intend on sticking with it ?

@networkfusion
Copy link
Owner

Yes the version in n64-tools, is is a hybrid of the official libdragon, conkers version and my own. I dont like the way the official version has to build GCC in order to build the lib and their new docker build is irrelevant... I have split them and use automated CICD for each (which is how it should be done). I may have a switch that supports both in future, or even switch to n64chain but that will only come once I start on the UI again... If you see any bug fixes in the official version that would benefit in my custom one, feel free to point them out.

@gameblabla
Copy link
Author

gameblabla commented Aug 23, 2019

I should mention that libdragon's upstream code still has the toolchain script :
https://github.com/DragonMinded/libdragon/blob/master/tools/build
In fact that's how i built it because docker was not working for me.

Conker's libdragon doesn't have stuff like the ones below
DragonMinded/libdragon#41
DragonMinded/libdragon#37
DragonMinded/libdragon#60

It is very behind upstream which has seen several fixes since then. It would be nice to merge libconker's libdragon changes if you need any changes from that... But didn't he merge those anyway ?

@networkfusion
Copy link
Owner

Ok, I will think about those changes. If some of conkers changes were rolled into the main libdragon repo I would probably swap back... but I may also make the version optional... but since the build process is automated and the download is available for both platforms, I don't see it as a showstopper and a very nice optimisation...

@networkfusion
Copy link
Owner

I have now added most of the relevant libdragon changes (c++ single entry point still causes issues, so I am still wondering how to handle it). I will also consider how the changes from conker64 can be made into a pull request to the main repo, so that way I can change back... the main differences are around RSP being implemented very differently... but altra64 doesnt use it, so may just be a non issue...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants