-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileUpload::getSanitizedName returns wrong file extension #239
Comments
Shall I prepare a PR for the suggested solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: 3.3.0
Bug Description
When uploading file.xls, method getSanitizedName() returns file.doc instead of file.xls.
Steps To Reproduce
Create a file upload and upload Microsoft Excel file with the old extension .xls. Dump FileUpload::getSanitizedName().
Expected Behavior
Method for returning sanitize name should return file.xls
Possible Solution
I've noticed, that the behavior of this method changed in the 3.2.4. The intention of the change was probably to return the correct extension for the image file uploads, but this change broke backwards compatibility for other types of files. Possible solution is to use finfo_file only for images?
The text was updated successfully, but these errors were encountered: