Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: "Call to a member function count() on null" #270

Closed
rvock opened this issue Feb 7, 2024 · 2 comments
Closed

Regression: "Call to a member function count() on null" #270

rvock opened this issue Feb 7, 2024 · 2 comments
Labels
unsupportedPHP

Comments

@rvock
Copy link
Contributor

rvock commented Feb 7, 2024

Bug description
When opening the page view of a page, you sometimes get the error "Call to a member function count() on null".

Steps to reproduce

  1. Update from 11.0.14 to v11.0.15
  2. Open the page view for a page
Exception

The regression was introduced with 34bd1ae
@m-huether
Copy link

It seems that the bugfix "($node->childNodes !== null) && ..." from previous versions has disappeared in v11.0.15.

@CybotTM
Copy link
Member

CybotTM commented Feb 22, 2024 •
edited
Loading

According to discussion for 34bd1ae

This is due to an outdated PHP version.

CybotTM added a commit that referenced this issue Feb 22, 2024
@CybotTM
fix #270: circumvent PHP < 7.4.4 bug with childNodes being NULL
864756a 
We need to explicitly check with hasChildNodes() and cannot just iterate over childNodes due to a bug in PHP < 7.4.4 https://bugs.php.net/bug.php?id=79271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unsupportedPHP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvock @CybotTM @m-huether