Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReduxFxml create function; shouldn't it take a store (v0.4.1)? #67

Open
chris-jan-dudley opened this issue Dec 19, 2017 · 2 comments
Open

Comments

@chris-jan-dudley
Copy link

Hi Guys,

We've been using ReduxFx, and following your ReduxFxml example. in the FxmlExample.java file you have the following line (34):

ReduxFxml<AppState> reduxFxml = ReduxFxml.create(store);

However, in our project, pulling the latest version from Maven (v0.4.1) the create function does not seem to take a ReduxFXStore parameter, as your example code suggests? Is this a known inconsistency, or is the example outdated?

Many thanks!

@manuel-mauky
Copy link
Contributor

This change was done in the latest commit.
This example code shows the usage of v0.4.2-SNAPSHOT.

So the example code is consistent for v0.4.2 but not v0.4.1.
However, as this is an API breaking change the version isn't compatible with semantic versioning.
Should it be v0.5.0?

@mizo432
Copy link

mizo432 commented Feb 20, 2018

I'm waiting v0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants