You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
git-gateway is forwarding some Headers it should not (X-Forwarded-For, Client-IP), which may trigger undesired behaviors (see #41 )
- If the current behavior is a bug, please provide the steps to reproduce.
We have detected than when forwarding the Client-IP header to GitLab, its api detected an Spoofing attempt (because X-Forwarded-For and Client-IP did not match)
- What is the expected behavior?
Forwarded request should be clean of unneeded headers.
- Please mention your Go version, and operating system version.
The text was updated successfully, but these errors were encountered:
it could be useful to get a build running on staging that logs all request headers, so you can know which to filter.
alternatively, an allow-list would make sense, because we can lookup what headers can be passed to those APIs
- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
git-gateway is forwarding some Headers it should not (X-Forwarded-For, Client-IP), which may trigger undesired behaviors (see #41 )
- If the current behavior is a bug, please provide the steps to reproduce.
We have detected than when forwarding the
Client-IP
header to GitLab, its api detected an Spoofing attempt (becauseX-Forwarded-For
andClient-IP
did not match)- What is the expected behavior?
Forwarded request should be clean of unneeded headers.
- Please mention your Go version, and operating system version.
The text was updated successfully, but these errors were encountered: