Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php bin/console ngscheduledvisibility:update for big installations new option --process_last_items_limit #4

Open
fwoldt opened this issue Jun 27, 2024 · 3 comments

Comments

@fwoldt
Copy link

fwoldt commented Jun 27, 2024

For big installation it could be a problem to process everytime all articles
in the script php bin/console ngscheduledvisibility:update

a good option could be to sort the objects by modified date and only process the last xxx items --process_last_items_limit ...

@pspanja
Copy link
Member

pspanja commented Jun 27, 2024

Indeed we can implement that, how would you prefer to define the last items?
Perhaps in days would be OK, for example --since=30 to process all items modified in last 30 days?

Just note that would not be bulletproof, as it would for example skip something that was updated more than 30 days ago to be visible after more than 30 days. But it would definitely be useful with some constraints.

BTW, once the items are in persistent cache (so basically on a repeated run), on my machine ~50k items are processed in ~30 seconds, which I think is not slow at all.

@fwoldt
Copy link
Author

fwoldt commented Jun 27, 2024

oh that's pretty fast .... days should be a good value ... the option would be good for testing, too ;-) modified --since=1 (day) to disable check of old items which may make problems

@pspanja
Copy link
Member

pspanja commented Jun 28, 2024

Now implemented and released as 1.0.0-rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants