NGSTACK-351: make compiler passes compatible with SF 2.8 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
reviewed
Oct 2, 2019
emodric
approved these changes
Oct 2, 2019
hknezevic
approved these changes
Oct 2, 2019
hknezevic
approved these changes
Oct 2, 2019
|
Is anyone still interested in this? Otherwise I will close it as it got a bit stale by now. |
|
Closing as obsolete. Feel free to reopen if interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
I didn't use if/else logic as suggested in the issue. Since original
IndexableRichTextandIndexableXmlTextdo not have any arguments it should be safe to useaddArgument.For
FieldTypeRegistryit should be enough to usereplaceArgumentwithout check, because if anything changes in the original class we will need to adapt our implementation anyway.